Follow up on #760 by adding regression coverage for the rocFFT behavior changed there.
The tests added in #760 cover the separate test_common.hpp one-past-end fix, but do not exercise the rocFFT validation changes.
Add tests covering:
- A stride layout that was previously accepted incorrectly and is now rejected.
- A non-unit innermost stride requiring the stride multiplier during packed-layout validation.
- A rank-4 descriptor being rejected with
oneapi::math::unimplemented.
The tests should explicitly assert the expected commit result rather than treating unimplemented as a skipped compute test.
Since rocFFT is not currently available in CI, consider extracting the stride-validation logic into a hardware-independent helper so the first two cases can run in regular CI. Backend integration tests may remain gated on
ONEMATH_ENABLE_ROCFFT_BACKEND.
Acceptance criteria
Follow up on #760 by adding regression coverage for the rocFFT behavior changed there.
The tests added in #760 cover the separate
test_common.hppone-past-end fix, but do not exercise the rocFFT validation changes.Add tests covering:
oneapi::math::unimplemented.The tests should explicitly assert the expected commit result rather than treating
unimplementedas a skipped compute test.Since rocFFT is not currently available in CI, consider extracting the stride-validation logic into a hardware-independent helper so the first two cases can run in regular CI. Backend integration tests may remain gated on
ONEMATH_ENABLE_ROCFFT_BACKEND.Acceptance criteria
oneapi::math::unimplemented.