Remove ONEDPL_WORKAROUND_FOR_IGPU_64BIT_REDUCTION - #2766
Open
dmitriy-sobolev wants to merge 2 commits into
Open
dmitriy-sobolev wants to merge 2 commits into
dmitriy-sobolev wants to merge 2 commits into
Conversation
dmitriy-sobolev
force-pushed
the
dev/dmitriy-sobolev/remove-reduce-workaround
branch
from
August 10, 2026 08:59
9f59ac5 to
c9bfad2
Compare
dmitriy-sobolev
force-pushed
the
dev/dmitriy-sobolev/remove-reduce-workaround
branch
2 times, most recently
from
August 12, 2026 15:10
96db097 to
6d6bfae
Compare
Base automatically changed from
dev/dmitriy-sobolev/fix-group-algo-trigger
to
main
August 13, 2026 17:53
dmitriy-sobolev
force-pushed
the
dev/dmitriy-sobolev/remove-reduce-workaround
branch
from
August 13, 2026 17:53
6d6bfae to
0c5a42b
Compare
dmitriy-sobolev
marked this pull request as ready for review
August 17, 2026 09:11
dmitriy-sobolev
force-pushed
the
dev/dmitriy-sobolev/remove-reduce-workaround
branch
from
August 21, 2026 15:28
9f07f78 to
388a00b
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the obsolete iGPU 64-bit reduction workaround and restores normal reduction paths and test coverage.
Changes:
- Removes workaround logic and CMake configuration.
- Re-enables 64-bit reduction and multiplication tests.
- Updates documentation and release notes.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
CMakeLists.txt |
Removes the workaround option handling. |
cmake/README.md |
Removes the obsolete option documentation. |
documentation/release_notes.rst |
Records the workaround removal. |
include/oneapi/dpl/pstl/hetero/dpcpp/unseq_backend_sycl.h |
Enables group reductions for 64-bit arithmetic types. |
test/CMakeLists.txt |
Removes the workaround-specific test variant. |
test/kt/single_pass_scan.cpp |
Enables 64-bit multiplication tests. |
test/parallel_api/numeric/numeric.ops/reduce_by_segment.pass.cpp |
Enables 64-bit device tests. |
test/support/test_config.h |
Removes obsolete test guards. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
dmitriy-sobolev
force-pushed
the
dev/dmitriy-sobolev/remove-reduce-workaround
branch
from
September 7, 2026 11:13
388a00b to
b54bde7
Compare
dmitriy-sobolev
force-pushed
the
dev/dmitriy-sobolev/remove-reduce-workaround
branch
from
September 7, 2026 11:29
b54bde7 to
a207aa8
Compare
dmitriy-sobolev
force-pushed
the
dev/dmitriy-sobolev/remove-reduce-workaround
branch
from
September 7, 2026 11:32
a207aa8 to
64b5bbf
Compare
Contributor
Author
|
I'm reluctant to proceed to these changes for 2022.15 release as 2350.150 driver version may still be used by somebody, because it still claims some degree of support. I think it is better to wait for some time until it is not supported (entirely). This PR is still useful, as it gather the information and has all needed changes, so I will keep it open. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The underlying issue was fixed ~2 years ago in the Intel® Graphics Driver. Even the oldest maintained LTS driver has the fix.
The fix in IGC: intel/intel-graphics-compiler@c7f30fd (October 2024).
LTS driver without the fix: 2350.150 (no longer maintained, but still promises limited support).
LTS driver with the fix: any 2523.x and newer.