Open
Conversation
Add the `-s`/`--sysroot` option present in upstream util-linux but previously missing. All hardcoded `/sys/` and `/proc/` paths in `sysfs.rs` are threaded through a `root: &Path` parameter; the default root is `/` so behaviour without the flag is unchanged. To support this cleanly, introduce a new local shared crate `uulinux` with a `join_under_root(root, path) -> PathBuf` helper that prepends a sysroot to an absolute system path without discarding the root (unlike `Path::join`). Also use it in `lsmem` to replace the existing hand-rolled path construction there. Add unit tests for `join_under_root` and Linux integration tests for `lscpu --sysroot` using a minimal fake sysfs/procfs tree.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the
-s/--sysrootoption present in upstream util-linux but previously missing. All hardcoded/sys/and/proc/paths insysfs.rsare threaded through aroot: &Pathparameter; the default root is/so behaviour without the flag is unchanged.To support this cleanly, introduce a new local shared crate
uulinuxwith ajoin_under_root(root, path) -> PathBufhelper that prepends a sysroot to an absolute system path without discarding the root (unlikePath::join). Also use it inlsmemto replace the existing hand-rolled path construction there.Add unit tests for
join_under_rootand Linux integration tests forlscpu --sysrootusing a minimal fake sysfs/procfs tree.