Date parse datetime 0.15 fixes#13284
Open
sylvestre wants to merge 3 commits into
Open
Conversation
parse_datetime 0.15 returns ParsedDateTime instead of jiff::Zoned; unwrap the in-range value via into_zoned() at the call sites and treat out-of-range (Extended) years as unparseable input.
jiff renders %s by truncating toward zero, but GNU date floors toward negative infinity (e.g. `@-1.5` -> -2, not -1). Every other field jiff produces already matches GNU, so rewrite only the %s specifier to the floored epoch second (via parse_datetime's unix_epoch_second) before handing the format string to jiff. Fixes uutils/parse_datetime#283
parse_datetime 0.15 accepts a 12-hour meridiem suffix on a combined date+time (e.g. `2024-06-15 12:00 PM`); enable and extend the previously-ignored regression test. Fixes uutils/parse_datetime#282
sylvestre
force-pushed
the
date-parse_datetime-0.15-fixes
branch
from
0152e69 to
7d526cb
Compare
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.