cp: implement sparse copy support for windows#12686
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
|
GNU testsuite comparison: |
|
@oech3 Ready for review. Failing check is unrelated to these changes. |
|
please add or enable relevant tests, thanks |
There are three new tests for this feature on windows, since this is windows specific PR. Is there anything else I could have done that I missed? |
|
@sylvestre bump |
1 similar comment
|
@sylvestre bump |
Alonely0
left a comment
There was a problem hiding this comment.
Barring a few issues, this looks like a great addition. However, I find myself wishing we could use a safe API of the windows-*/winapi_util crates, instead of raw win32 unsafe calls. If it's not available there, would you add safe wrappers of these to uucore::fs and use them here?
Also, can someone more familiar with Windows I/O take a second look? I can only comment on my limited experience here.
Attempts to fix: #12186