Repository navigation
perf(db): configurable SQLite WAL synchronous level (#437) - #1239
Open
harshitethic wants to merge 2 commits into
Open
harshitethic wants to merge 2 commits into
harshitethic wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #437. Use PRAGMA synchronous=NORMAL after WAL mode by default; allow CONCORD_SQLITE_SYNCHRONOUS=normal|full, validated at config load and propagated to control and workspace connections. Document the durability tradeoff in .env.example. Two regression tests verify both PRAGMAs, workspace propagation, defaults and invalid settings. Local Vitest, API typecheck and ESLint passed. Microbenchmark on the Linux validation VPS: 400 independent autocommit inserts, FULL 398.9 ms and NORMAL 7.9 ms (single run, environment-specific, not a performance guarantee). AI-assisted; review welcome.