Repository navigation
Clarify third-party verification prerequisites - #535
simonpeters298 wants to merge 1 commit into
Conversation
|
Needs changes The pull request attempts to address issue #455 by adding prerequisites to the verification guide and recording session notes. However, the session notes explicitly state that the review was performed by GitHub Copilot rather than a person outside the project, violating the core acceptance criteria of having 'someone outside the project follow docs/verifying.md from scratch'. Blocking
|
There was a problem hiding this comment.
Needs changes
The pull request attempts to address issue #455 by adding prerequisites to the verification guide and recording session notes. However, the session notes explicitly state that the review was performed by GitHub Copilot rather than a person outside the project, violating the core acceptance criteria of having 'someone outside the project follow docs/verifying.md from scratch'.
Blocking
docs/sessions/2026-10-22-third-party-verification.md:7
Problem: The acceptance criteria for #455 require an independent walkthrough by someone new outside the project, but this session was performed by GitHub Copilot in the workspace.
Suggested fix: Remove the automated AI session notes or replace them with notes from an actual external human reviewer as required by issue #455.
Prompt for an AI coding agent
In docs/sessions/2026-10-22-third-party-verification.md around line 7, replace the automated AI review notes with notes from an actual human outside the project following the guide from scratch, as mandated by issue #455.
Reviewed commit: d7c6e388a06d9d75be4844a576d9f121645ae657.
|
MergeKeeper review unavailable AI provider failed: gemini-3.5-flash-lite (200) No approval or merge action was taken. |
SummaryClarifies the setup and stop conditions for someone following
Session resultsOn Ubuntu 24.04.5, This automated walkthrough was not performed by an external person and does not satisfy the independent human-review requirement in #455. Issue #455 therefore remains open; a third-party human should follow the updated guide and append elapsed time, environment, failures, and remaining confusion to the session notes. Validation
|
|
corrected |
|
Thanks for clarifying the verification prerequisites. That part is useful. The PR also adds session notes saying the review was done by an AI assistant, which don't belong in the repository. To get it merged: drop the session-notes file, keep only the prerequisites change to the verification guide, and rebase onto |
Summary
Clarifies the setup and stop conditions for someone following
docs/verifying.mdfrom a fresh environment.devel#278../assaycommands rely on continuing in theassay-checkdirectory.docs/sessions/2026-10-22-third-party-verification.md.Session results
On Ubuntu 24.04.5,
gh release list --repo use-assay/assayreturned no releases. The documentedv0.1.0download was attempted in a temporary directory and failed withrelease not found(measured command runtime: 0 seconds). No release binary was available, so steps 0b-6 could not be run.This automated walkthrough was not performed by an external person and does not satisfy the independent human-review requirement in #455. Issue #455 therefore remains open; a third-party human should follow the updated guide and append elapsed time, environment, failures, and remaining confusion to the session notes.
Validation
git diff --checkpassed.