Skip to content

Clarify third-party verification prerequisites - #535

Open
simonpeters298 wants to merge 1 commit into
use-assay:mainfrom
simonpeters298:research/453-455-assay-and-verification
Open

simonpeters298 wants to merge 1 commit into
use-assay:mainfrom
simonpeters298:research/453-455-assay-and-verification

Conversation

@simonpeters298

@simonpeters298 simonpeters298 commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Clarifies the setup and stop conditions for someone following docs/verifying.md from a fresh environment.

  • Adds required tools, the pinned Stellar CLI version, and official installation links.
  • Adds an up-front release check and explains that a local build is not a substitute for release provenance. The missing published release is already tracked by Cut tagged releases so the bound scanner identity is something other than devel #278.
  • Makes explicit that later ./assay commands rely on continuing in the assay-check directory.
  • Records the automated workspace walkthrough and validation limits in docs/sessions/2026-10-22-third-party-verification.md.

Session results

On Ubuntu 24.04.5, gh release list --repo use-assay/assay returned no releases. The documented v0.1.0 download was attempted in a temporary directory and failed with release not found (measured command runtime: 0 seconds). No release binary was available, so steps 0b-6 could not be run.

This automated walkthrough was not performed by an external person and does not satisfy the independent human-review requirement in #455. Issue #455 therefore remains open; a third-party human should follow the updated guide and append elapsed time, environment, failures, and remaining confusion to the session notes.

Validation

  • Ran the documented release preflight; it reports no releases, matching the new stop condition.
  • git diff --check passed.
  • VS Code diagnostics reported no errors in either changed Markdown file.

@mergekeeper

mergekeeper Bot commented Oct 22, 2026

Copy link
Copy Markdown

Needs changes

The pull request attempts to address issue #455 by adding prerequisites to the verification guide and recording session notes. However, the session notes explicitly state that the review was performed by GitHub Copilot rather than a person outside the project, violating the core acceptance criteria of having 'someone outside the project follow docs/verifying.md from scratch'.


Blocking

docs/sessions/2026-10-22-third-party-verification.md:7

Problem: The acceptance criteria for #455 require an independent walkthrough by someone new outside the project, but this session was performed by GitHub Copilot in the workspace.

Suggested fix: Remove the automated AI session notes or replace them with notes from an actual external human reviewer as required by issue #455.

Prompt for an AI coding agent
In docs/sessions/2026-10-22-third-party-verification.md around line 7, replace the automated AI review notes with notes from an actual human outside the project following the guide from scratch, as mandated by issue #455.

Reviewed commit: d7c6e388a06d9d75be4844a576d9f121645ae657.

@mergekeeper mergekeeper Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs changes

The pull request attempts to address issue #455 by adding prerequisites to the verification guide and recording session notes. However, the session notes explicitly state that the review was performed by GitHub Copilot rather than a person outside the project, violating the core acceptance criteria of having 'someone outside the project follow docs/verifying.md from scratch'.


Blocking

docs/sessions/2026-10-22-third-party-verification.md:7

Problem: The acceptance criteria for #455 require an independent walkthrough by someone new outside the project, but this session was performed by GitHub Copilot in the workspace.

Suggested fix: Remove the automated AI session notes or replace them with notes from an actual external human reviewer as required by issue #455.

Prompt for an AI coding agent
In docs/sessions/2026-10-22-third-party-verification.md around line 7, replace the automated AI review notes with notes from an actual human outside the project following the guide from scratch, as mandated by issue #455.

Reviewed commit: d7c6e388a06d9d75be4844a576d9f121645ae657.

@mergekeeper

mergekeeper Bot commented Oct 24, 2026

Copy link
Copy Markdown

MergeKeeper review unavailable

AI provider failed: gemini-3.5-flash-lite (200)

No approval or merge action was taken.

@simonpeters298

Copy link
Copy Markdown
Contributor Author

Summary

Clarifies the setup and stop conditions for someone following docs/verifying.md from a fresh environment.

  • Adds required tools, the pinned Stellar CLI version, and official installation links.
  • Adds an up-front release check and explains that a local build is not a substitute for release provenance. The missing published release is already tracked by Cut tagged releases so the bound scanner identity is something other than devel #278.
  • Makes explicit that later ./assay commands rely on continuing in the assay-check directory.
  • Records the automated workspace walkthrough and validation limits in docs/sessions/2026-10-22-third-party-verification.md.

Session results

On Ubuntu 24.04.5, gh release list --repo use-assay/assay returned no releases. The documented v0.1.0 download was attempted in a temporary directory and failed with release not found (measured command runtime: 0 seconds). No release binary was available, so steps 0b-6 could not be run.

This automated walkthrough was not performed by an external person and does not satisfy the independent human-review requirement in #455. Issue #455 therefore remains open; a third-party human should follow the updated guide and append elapsed time, environment, failures, and remaining confusion to the session notes.

Validation

  • Ran the documented release preflight; it reports no releases, matching the new stop condition.
  • git diff --check passed.
  • VS Code diagnostics reported no errors in either changed Markdown file.

@simonpeters298

Copy link
Copy Markdown
Contributor Author

corrected

@samjay8

samjay8 commented Oct 25, 2026

Copy link
Copy Markdown
Contributor

Thanks for clarifying the verification prerequisites. That part is useful. The PR also adds session notes saying the review was done by an AI assistant, which don't belong in the repository.

To get it merged: drop the session-notes file, keep only the prerequisites change to the verification guide, and rebase onto main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants