Repository navigation
Conversation
|
@GOE001 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
MergeKeeper review Scope: in scope for linked issue The PR successfully adds a comprehensive research deliverable in docs/consumer-integration-research.md comparing three candidate consumers (Soroswap allowlist, DeFindex vault, and Blend lending pool) using real deployed protocol references, evaluating their needs against Assay's interface, and providing a reasoned recommendation. Reviewed commit: |
|
MergeKeeper merge status Status: blocked Reason: One or more required CI checks failed. Failing checks:
Next steps:
|
A run of merge commits on main resolved conflicts by keeping both sides instead of the intended union. That duplicated type and function declarations (mechanics, api, scan, cmd/assay), dropped shared helpers (write_attestation was still called but gone from horizon and stellarexpert and sep1), reverted a few type changes (CanonicalTime, Answer[T], Options), and left several test files with two copies of the same helper. `go build`, `go vet`, `go test`, `cargo fmt`, `cargo clippy` and `cargo test` all failed as a result, so every open PR inherited a red build. Reconstruct the intended unions, restore the dropped definitions, align the tests with the behaviors the newer branches added (blocked-lookup skip is undetermined, evidence timestamps are canonical and carry a requested URL, reputation is cached), and regenerate the Soroban test snapshots for the pinned toolchain and soroban-sdk 28. This is deliberately a scoped main-only repair: the feature PRs keep their own diffs, and land green once this is on main.
|
Needs review Linked to This PR introduces research on get_safety consumer integration as requested by issue #153, but it also includes unrelated workflow edits and domain check logic changes in internal/mechanics/check_domain.go that belong to separate tasks. Reviewed commit: |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 participant
closed #153