Skip to content

feat: Microsoft 365 and Google connected at the same time, merged review #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
urnlahzer merged 2 commits into from
Oct 5, 2026
Merged

feat: Microsoft 365 and Google connected at the same time, merged review #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ccb8e4b
feat: Google Tasks reminders for Gmail accounts (CONTRACT EDIT FOR OW…
urnlahzer Oct 4, 2026
bf63168
feat: Microsoft 365 and Google connected at the same time, merged review
urnlahzer Oct 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1,420 changes: 1,194 additions & 226 deletions crates/openloops-desktop/src/app_model.rs
View file
Open in desktop

Large diffs are not rendered by default.

17 changes: 9 additions & 8 deletions crates/openloops-desktop/src/loop_state.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,9 @@ const CAP: usize = 55;
/// unbounded, so the `CAP` rejection in `update()` stays rare under ordinary
/// use while still bounding the store's size.
const TERMINAL_EXPIRY_SECONDS: i64 = 180 * 86400;
/// Bound on each Graph id stored in `Reminder::Created`, chosen to fit a
/// single-byte length prefix (real Microsoft Graph To Do list/task ids are
/// consistently well under this). Given the same 2560-byte credential-blob
/// Bound on each provider task-list or task id stored in `Reminder::Created`,
/// chosen to fit a single-byte length prefix (real Microsoft To Do and Google
/// Tasks list/task ids are consistently well under this). Given the same 2560-byte credential-blob
/// ceiling `CAP` is sized against, storing two such ids alongside every
/// record is not something a raised `CAP` could also absorb; a save that
/// would exceed the blob size still fails safely via `encode()`'s existing
Expand All @@ -53,8 +53,8 @@ pub enum Reminder {
#[default]
None,
Attempted,
/// Carries the Graph task-list and task id `reminders::create()`
/// resolved, so a later action (marking it complete once the card is
/// Carries the provider plus the task-list and task id its adapter's
/// `create()` resolved, so a later action (marking it complete once the card is
/// Handled) can address the same task -- see `reminders::complete()`.
/// Each id is bounded to `MAX_REMINDER_ID_LEN` bytes for storage; see
/// that constant for why.
Expand All @@ -63,8 +63,9 @@ pub enum Reminder {
list_id: String,
task_id: String,
},
/// Set only by the reminder-sync check (`reminders::check_status`)
/// finding the linked task already completed in Microsoft To Do --
/// Set only by the reminder-sync check (`provider::reminder_status`)
/// finding the linked task already completed in Microsoft To Do or
/// Google Tasks --
/// never by the user clicking Handled, which leaves `reminder` as
/// `Created` even after `reminders::complete()` succeeds. This is the
/// one thing that distinguishes "the user marked this handled" from
Expand Down Expand Up @@ -393,7 +394,7 @@ pub fn marker(key: &[u8; 32]) -> String {
})
}

/// Appends one Graph id as a single-byte length prefix followed by its
/// Appends one provider task-list or task id as a single-byte length prefix followed by its
/// bytes. Fails rather than silently truncating an id over
/// `MAX_REMINDER_ID_LEN` -- callers must reject or shorten it upstream
/// instead (see `reminders::valid_graph_id`, which already bounds ids this
Expand Down
Loading
Loading