Repository navigation
Conversation
…NER REVIEW)
PR-3 of docs/plans/2026-09-27-google-provider-and-shared-registration.md.
Contract edit: docs/adr/ADR-009-reminder-adapters.md gains an additive amendment recording
the Google Tasks adapter and the marker placement both adapters actually use (free-text body:
To Do body.content, Google Tasks notes; never title or due). The reminder checker's ADR hash
literal is re-pinned; P0-REMINDER-CROSS-CONTRACT-001 passes; the pre-existing
P0-REMINDER-INVENTORY-001 failure is unchanged; contracts/*.json untouched.
- graph live/google/tasks.rs: create / complete / check_status against the Google Tasks API
over the per-provider Google session with the tasks scope. create verifies the signed-in
account matches the scanned account before any request, takes the first task list as the
default, posts one task (title, needsAction, a date-only `due`, notes carrying the chosen
reminder time and the opaque OpenLoops reference) and reports Created only on HTTP 200 with
a usable id; anything after dispatch without that is the same uncertain outcome the
Microsoft adapter uses. Every request is origin-confined, bounded, redirect-free, one
request per attempt. A 401 clears only the Google session slot.
- graph live/provider.rs: create_reminder / complete_reminder / reminder_status dispatch on
the AccountConfig variant; the Microsoft arms call reminders.rs unchanged.
- desktop: reminder drafts, dispatch, completion and the sync job route by the record's
provider through account_config(provider); reminder_sync_checks groups by provider so one
job serves both; the PR-2b "later release" guard is gone; outcome texts name Google Tasks
for Google records and are unchanged for Microsoft.
- ui: the review draft reads reminder-service and reminder-time-note; for Google the note
states that Google Tasks saves the date only and does not alert, and that the chosen time
is written into the task's notes.
Review fixes (Opus read-only review, Opus implementer): `due` is the user's LOCAL calendar
date (an evening pick west of UTC no longer lands on the next day); a 401 on the completion
PATCH clears the Google session and never re-sends; Microsoft copy restored byte-identical
and pinned by tests; Google screens name Google Tasks everywhere ("To Do" / "Google Tasks"
short names keep Microsoft strings unchanged); one shared local-time formatter with UTC
offset; a list response without `items` is an empty list; reminder paths build the Microsoft
config without mail-loading shared/group inputs (reminder_account_config); sync planning
extracted to reminder_sync_jobs() and tested for both providers; facade and adapter guards
reject cross-provider requests; POST non-200 and post-dispatch transport failures are
Uncertain; the PATCH test asserts method and exact body.
Verified: cargo fmt --check; clippy -D warnings (graph live-connection, desktop
native-ui,ui-screenshot); graph 198 passed; desktop 459 passed, 0 failed, 3 ignored;
Cargo.lock unchanged; public-repo gate on staged files.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01YCesN8ZHnhqa6n3rWFThas
Owner
Author
|
Closing without merge: #63 ( Owner note: the ADR-009 contract edit described in this PR's body therefore landed through #63, whose title did not carry the "CONTRACT EDIT FOR OWNER REVIEW" flag. Please review the "Amendment (2026-10-04): Google Tasks adapter and marker placement" section of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
PR-3 of
docs/plans/2026-09-27-google-provider-and-shared-registration.md: a reviewed loop from a Gmail account can be turned into a Google Tasks task, with the same confirmation-first flow as Microsoft To Do. PR-4 (both providers connected at once) follows.Behaviour
Verification
cargo fmt --all -- --check; clippy-D warningson both crates: cleancargo test -p openloops-graph --features live-connection: 198 passedcargo test -p openloops-desktop --features native-ui -- --test-threads=1: 459 passed, 0 failed, 3 ignoredCargo.lockunchanged; public-repo gate passed on the staged filestools/check-reminder-adapter-boundary.ps1:P0-REMINDER-CROSS-CONTRACT-001passes with the re-pinned ADR hash; only the pre-existingP0-REMINDER-INVENTORY-001fails, as onmainContract edit for owner review:
docs/adr/ADR-009-reminder-adapters.mdgains an additive amendment recording the Google Tasks adapter and the marker placement both adapters use (free-text body: To Dobody.content, Google Tasksnotes; never title or due). The ADR's existing text says the raw marker travels only in a "proven opaque field"; neither service offers one, and the Microsoft adapter already used the body before this PR. The amendment records that, without claiming either field is proven.contracts/*.jsonuntouched.Not yet exercised live
No task has been created against a real Google account; loopback tests pin the request and response shapes. Smoke test after merge with the owner's Gmail test user: create a reminder from a Gmail loop, confirm the task appears in Google Tasks with the date and the notes line, then mark it done and confirm the card reconciles.
🤖 Generated with Claude Code
https://claude.ai/code/session_01YCesN8ZHnhqa6n3rWFThas