Repository navigation
feat(review): owner links between loops and conversations, with follow-up mentions - #56
Merged
Merged
Conversation
…w-up mentions
Adds a second credential (OpenLoops/Relations/v1, 34 links, fingerprints
only) holding SameLoop / NotSameLoop / SameThread / NotSameThread pairs keyed
by the existing loop fingerprints and a new conversation key under the same
secret. Cards gain a mentions list ("Asked again" evidence cards, "Asked Nx"
pill, sort ahead of other open cards) and a "Linked to" line. Two-step
select: press "Same loop as…" or "Same conversation as…", click the other
card, Esc cancels; "Not the same" flips a link to its negative. Same-loop
links fold the newer card into the older immediately; conversation links
take effect on the next scan (next PR). Training export writes rules.jsonl
with gold duplicate_action and thread_merge rows from the links. Scan
pipeline unchanged.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EKHrBckgsxYkTUEipKtwmU
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR 1 of 2 for owner-taught loop relations (plan: owner links and mentions now; restated follow-up detection, duplicate retention and thread-merge assertions after the loop-count regression is diagnosed).
link_state.rs): credentialOpenLoops/Relations/v1, 73-byte rows, cap 34, same compare-and-swap save and lock pattern as decisions;LoopKeysextracted fromDecisionsso both stores share one secret (golden fingerprint test unchanged). Kinds: SameLoop, NotSameLoop, SameThread, NotSameThread. Thread key = HMAC overopenloops-conversation-v1 | account | conversationId. Status bar: "N saved decisions · M links".LoopItem.mentions,fold_into): "Asked again" evidence cards with date and Open email link, "Asked Nx" pill, open cards with mentions sort first in their group, "Linked to" meta line.apply_loop_links, also run at the end ofset_scan); conversation links are stored now and applied to merging in PR 2.rules.jsonlwith goldrules.duplicate_actionrows (SameLoop true / NotSameLoop false) andrules.thread_mergerows (SameThread / NotSameThread), owner-sourced.mentions: Vec::new()onLoopItemliterals.Test plan
🤖 Generated with Claude Code
https://claude.ai/code/session_01EKHrBckgsxYkTUEipKtwmU