Repository navigation
chore(ci): add required build workflow for branch ruleset - #40
Conversation
Adds `.github/workflows/build.yml` with job `build` so default-branch protection can pass.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 49ddbbe077
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| yarn install --frozen-lockfile || yarn install | ||
| RUN="yarn" | ||
| else | ||
| if [ -f package-lock.json ]; then npm ci || npm install; else npm install; fi |
There was a problem hiding this comment.
When a PR changes package.json without updating package-lock.json, npm ci correctly exits with an error, but this fallback immediately runs npm install, updates the lockfile only inside the runner, and can let the required build check pass with an unreproducible dependency manifest. The npm ci documentation explicitly says it errors rather than updating an inconsistent lockfile, so remove the fallback and allow that failure to surface.
Useful? React with 👍 / 👎.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
1 participant
Adds
.github/workflows/build.ymlwith jobbuildso default-branch protection can pass.