Security update: bump sharp and other dependencies - #40
Merged
Conversation
Address security advisories by updating dependencies: - Upgrade sharp to ^0.35.3 (and commander ^15, @types/node ^26, jest/ts-jest/prettier) as part of the dependency refresh. - Pin brace-expansion to ^5.0.8 via `overrides` to resolve the brace-expansion DoS advisory (GHSA-mh99-v99m-4gvg) that surfaced through the jest dependency tree. `npm audit` now reports 0 vulnerabilities. - Bump CI to Node 26.x and actions/checkout & actions/setup-node v7. Update the SDF test fixtures (test6.png, test6@2x.png), regenerated with sharp 0.35. The decoded pixels are identical to the previous fixtures; only the PNG encoder byte stream changed. Switch checkFileMatchesFixture from an md5 byte comparison to a sharp(...).raw() pixel comparison so that PNG encoder changes (such as a bundled libvips/zlib update in sharp) no longer break the tests as long as the resulting image is pixel-identical. Refs #39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #39
Summary
sharpto^0.35.3(pluscommander^15,@types/node^26, and jest/ts-jest/prettier) as part of a dependency refresh.brace-expansionto^5.0.8viaoverridesto resolve the brace-expansion DoS advisory (GHSA-mh99-v99m-4gvg) that surfaced through the jest dependency tree.npm auditnow reports 0 vulnerabilities.26.xandactions/checkout/actions/setup-nodev7.Test fixtures
test6.png,test6@2x.png) with sharp 0.35. The decoded pixels are identical to the previous fixtures (same dimensions, metadata, PNG chunk structure, and IDAT length); only the compressed PNG byte stream changed due to the bundled libvips/zlib update.checkFileMatchesFixturefrom an md5 byte comparison to asharp(...).raw()pixel comparison, so future PNG encoder changes no longer break the tests as long as the image is pixel-identical.Verification
npm test→ 16/16 passing (4 suites).npm audit→ 0 vulnerabilities.Note: remaining
npm installpeer-dependency warnings originate from an optional wasm binding inunrs-resolver(pulled in transitively by jest) and are harmless upstream noise; nothing in this repo can address them.