move to OIDC for npm publish - #36
Merged
Merged
Conversation
- add publish.yml triggered by v* tags with provenance support - add repository field to package.json for provenance - switch build.yml to npm ci closes #35
There was a problem hiding this comment.
Pull request overview
Adds an OIDC-based npm publishing workflow on version tag pushes, enabling npm provenance and aligning CI installs with lockfile-based reproducibility.
Changes:
- Add
.github/workflows/publish.ymlto publish to npm onv*tags using OIDC (id-token: write) andnpm publish --provenance. - Add
repositorymetadata topackage.json(required for provenance generation). - Update CI install step in
build.ymlfromnpm installtonpm ciand remove the unusedNODE_AUTH_TOKEN.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Adds repository metadata needed for npm provenance. |
| .github/workflows/publish.yml | New tag-triggered npm publish workflow using OIDC + provenance. |
| .github/workflows/build.yml | Switches dependency installation to npm ci for reproducible CI builds. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
LGTM and thank you for updating. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v*タグのpush時にnpmへ公開するpublish.ymlワークフローを追加（OIDC provenance対応）package.jsonにrepositoryフィールドを追加（provenance生成に必要）build.ymlのnpm installをnpm ciに変更し、不要なNODE_AUTH_TOKENを削除closes #35
Test plan
v*タグをpushしてワークフローが正常に動作することを確認