Repository navigation
[Bugfix] Fix bounding box offset for multi-node models selected via scenegraph - #157
Merged
Merged
Conversation
…cenegraph Selecting a dragged-in multi-node asset (e.g. goalpost) in the scenegraph highlighted a bounding box offset from the visible mesh. The highlight accumulation composed each child's bbox contribution using the parent's own local transform instead of the child's, so a mesh living on a child entity with its own position offset from its container root rendered its box in the wrong place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
goalpost.untold) via the scenegraph highlighted a bounding box offset from the visible mesh.accumulateBoundsInRootSpace/accumulateRenderableBoundsInRootSpaceinSelectionManager.swiftcomposed each child's bbox contribution using the parent's own local transform instead of the child's own local transform. This is invisible for a flat single-mesh entity, but a multi-node asset (container root + child mesh entities, each with their own local offset) got its highlight box computed as if children sat at the parent's own transform rather than their own.LocalTransformComponentand compose that with the accumulated chain, instead of reusing the current entity's transform.Test plan
test_selectingAContainer_highlightsItsOffsetChildsMeshinSelectionSeveralTests.swift, reproducing the container-root + offset-child shape and reading back the GPU highlight buffer directly.