Repository navigation
Add getPromiseState tests for non-promise values - #205
Merged
Merged
Conversation
Assert current behavior for undefined, null, booleans, numbers, strings, arrays, objects, symbols, and bigints. Also cover that plain objects are not cached, and that an object with a non-function `then` throws. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds tests that lock in how
getPromiseStatehandles non-promise values today. No behavior changes.What's covered
undefined, created in module state and inside a templatenull,false,true,0,NaN,1,'',[],[1, 2],{},{ a: 1 }, a symbol, a bigint{ isLoading: false, error: null, resolved: value }right away, andresolvedis the exact value passed in[], since Glimmer's{{#if}}treats empty arrays as falsy) render none of theisLoading/error/resolvedbranchesthen(e.g.{ then: 1 }) throws aTypeError.isThennableonly checks'then' in x, and the.then(...)call is outside thetryThe last two might not be what we want long-term. They're here so any change to them is deliberate.
🤖 Generated with Claude Code