feature: allow noise to depend on simulation - #151
Merged
Conversation
behinger
commented
Nov 11, 2025
jschepers
reviewed
Nov 11, 2025
| end | ||
|
|
||
| simulate_noise(rng::AbstractRNG, t::AbstractNoise, signal, Simulation::Simulation) = | ||
| simulate_noise(rng, t, prod(signal)) |
Collaborator
There was a problem hiding this comment.
@behinger Warum kommt hier prod(signal) vor? Wenn ich die Dokumentation von prod richtig verstanden habe, dann multipliziert prod alle elemente einer collection.
Aber warum multipliziert man alle Elemente aus signal?
behinger
commented
Nov 12, 2025
behinger
commented
Nov 12, 2025
Co-authored-by: Benedikt Ehinger <benedikt.ehinger@vis.uni-stuttgart.de>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
jschepers
reviewed
Nov 12, 2025
Comment on lines
+41
to
+47
| # ExponentialNoise: returns correct length and differs for different seeds | ||
| e1 = simulate_noise(deepcopy(rng), ExponentialNoise(noiselevel = 1, ν = 1.2), n) | ||
| e2 = | ||
| simulate_noise(deepcopy(StableRNG(2)), ExponentialNoise(noiselevel = 1, ν = 1.2), n) | ||
| @test size(e1) == (n,) | ||
| @test size(e2) == (n,) | ||
| @test !(all(isapprox.(e1, e2; atol = 0, rtol = 1e-12))) |
Collaborator
There was a problem hiding this comment.
@behinger I assume this will fail for the new ExponentialNoise implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.