Skip to content

added new exponential noise implementation - #129

Merged
jschepers merged 10 commits into
mainfrom
exponential-noise
Nov 12, 2025
Merged

added new exponential noise implementation#129
jschepers merged 10 commits into
mainfrom
exponential-noise

Conversation

@behinger

Copy link
Copy Markdown
Member

No description provided.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@behinger

Copy link
Copy Markdown
Member Author

what I dont yet like:
-> The default dropoff of 1000 should actually depend on the sampling rate, but it cant, becaue we are agnotistc to the samplig rate. So either we should provide a generator with sampling rate which interanlly reparameterizes tau to from time to samples, or we should not provide a default. Else the noise properties change drastically when changing sampling frequency

@jschepers

jschepers commented Nov 11, 2025

Copy link
Copy Markdown
Collaborator

@behinger Did you also have a look at the Reference docs page about Noise types? If everything fits for the new implementation.
And I guess the hint on the bottom of the page, needs to be adapted, right?
https://unfoldtoolbox.github.io/UnfoldSim.jl/previews/PR129/generated/reference/noisetypes/

Comment thread src/noise.jl
@behinger

Copy link
Copy Markdown
Member Author
  • fixed the hint
  • the size vs. length I changed because sometimes you don't want to have noise that 's "linearizeable", but rather produce it per event/subject whatever. prod(tuple) just calculates length out of the size-tuple

@jschepers

Copy link
Copy Markdown
Collaborator

I think the second point is not about this PR but one of the others.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@jschepers

Copy link
Copy Markdown
Collaborator

@behinger The label for ExponentialNoise in the Noise reference page needs fixing.
grafik

Comment thread test/noise.jl
@jschepers

jschepers commented Nov 12, 2025

Copy link
Copy Markdown
Collaborator

@behinger The label for ExponentialNoise in the Noise reference page needs fixing. grafik

I fixed it.
grafik

@jschepers
jschepers merged commit 28f2c92 into main Nov 12, 2025
4 checks passed
@jschepers
jschepers deleted the exponential-noise branch November 12, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants