feat(seed): replace the size tiers with the four Ley 187-17 categories - #613
Open
mrivas00 wants to merge 1 commit into
Open
feat(seed): replace the size tiers with the four Ley 187-17 categories#613mrivas00 wants to merge 1 commit into
mrivas00 wants to merge 1 commit into
Conversation
mrivas00
force-pushed
the
feat/mati/rd-schema-additions
branch
from
August 24, 2026 12:25
5df1bc3 to
a015d35
Compare
mrivas00
force-pushed
the
feat/mati/rd-organization-sizes
branch
from
August 24, 2026 12:25
4ef048b to
5ea7ed3
Compare
mrivas00
force-pushed
the
feat/mati/rd-schema-additions
branch
from
August 24, 2026 15:10
a015d35 to
fb37631
Compare
mrivas00
force-pushed
the
feat/mati/rd-organization-sizes
branch
2 times, most recently
from
August 24, 2026 17:58
43e2199 to
2e5cf76
Compare
mrivas00
force-pushed
the
feat/mati/rd-schema-additions
branch
from
August 24, 2026 17:58
fb37631 to
144ca97
Compare
mrivas00
force-pushed
the
feat/mati/rd-organization-sizes
branch
from
August 25, 2026 18:50
2e5cf76 to
871de55
Compare
mrivas00
force-pushed
the
feat/mati/rd-schema-additions
branch
from
August 26, 2026 12:12
6152fb0 to
80c901f
Compare
mrivas00
force-pushed
the
feat/mati/rd-organization-sizes
branch
from
August 26, 2026 12:12
871de55 to
f97ffee
Compare
mrivas00
force-pushed
the
feat/mati/rd-schema-additions
branch
from
August 26, 2026 12:36
80c901f to
ee08ab5
Compare
mrivas00
force-pushed
the
feat/mati/rd-organization-sizes
branch
from
August 26, 2026 12:36
f97ffee to
ac694ff
Compare
MMARN observed that the eight demo tiers do not match Dominican law. Ley 187-17 defines four: microempresa (hasta 10 trabajadores), pequeña (11 a 50), mediana (51 a 150) and grande. The tier stays independent of `employeesCount`: nothing derives one from the other and neither field is required, so an organization can declare its category without disclosing an exact headcount.
mrivas00
force-pushed
the
feat/mati/rd-schema-additions
branch
from
August 26, 2026 20:21
ee08ab5 to
87aaa3f
Compare
mrivas00
force-pushed
the
feat/mati/rd-organization-sizes
branch
from
August 26, 2026 20:21
ac694ff to
13393cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
MMARN observed that the organization-size catalog does not match Dominican law. The demo dataset ships eight tiers invented for the sample country ("Corporación multinacional (5000+ empleados)"); Ley 187-17 defines four.
PR 4 of 8 · base
feat/mati/rd-schema-additions(PR 3) · no migration.What
positionis assigned by the seed in file order, so the maintainer and the form present them smallest-first.Review notes
The size tier is independent of
employeesCount: nothing derives one from the other, and neither field is required on the form. An organization can therefore declare its Ley 187-17 category without disclosing an exact headcount — which is the point, since the law's categories also depend on gross annual sales, a figure the platform does not collect.The maintainer's explanation text is already generic about thresholds ("Cada Tamaño suele definir tramos en función de número de empleados, ingresos u otros criterios establecidos por el regulador"), so it stays accurate unchanged.
Verification
pnpm format && pnpm lint && pnpm type-checkgreen.Not verified here: task 5.3 asks to reseed and confirm the form offers exactly four tiers — no database was available in the authoring environment. Note that this replacement is one of the reasons the deployment needs the reset window (
seed.tsskips entirely whencountry.count() > 0), so it should be exercised there.