Skip to content

feat(seed): set the deployment country to República Dominicana - #610

Open
mrivas00 wants to merge 2 commits into
rd/integrationfrom
feat/mati/rd-deployment-identity
Open

feat(seed): set the deployment country to República Dominicana#610
mrivas00 wants to merge 2 commits into
rd/integrationfrom
feat/mati/rd-deployment-identity

Conversation

@mrivas00

@mrivas00 mrivas00 commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator

Why

MMARN reviewed the test environment and returned ten written observations. The first thing they see is a platform that calls itself "País Demo": the base seed dataset ships a demo country, and every catalog scoped by country hangs off its PD ISO code.

This is PR 1 of 8 on the rd/integration stack — the long-lived branch RD inherits, which is not merged back into Huella Latam. It goes first because the ISO sweep touches the six seed files that PRs 4, 6 and 8 rewrite; landing it later means those rewrites conflict with it.

What

  • countries.json: País Demo / PDRepública Dominicana / DO.
  • countryIsoCode swept from PD to DO across the six base seed files that scope rows by country: organization sizes, sector/subsectors, methodologies, job positions, main activities and subcategory recommendations (135 occurrences, all of them the country field — no other value in the dataset is "PD").
  • Methodology description follows the country name.
  • The OpenSpec change (proposal.md, design.md, tasks.md, five capability specs) is committed as the plan for the whole stack.

The testing dataset keeps its own País Demo fixture on purpose — it is test data, not deployment data, and API integration tests pin to it.

No schema change, no code change: no .ts/.tsx file references the ISO code, so the sweep is data-only.

Review notes

The change proposes five capabilities, not six. A sixth — an escape-hatch dimension value obliging its capture line to carry a comment — was originally proposed here and withdrawn in PR 8, once it turned out the rule could only match dimension values by name and so could not be scoped to one dimension without becoming a per-dimension rule. It never ships, so it is no longer proposed: a requirement delta in front of a reviewer that no code satisfies is worse than no delta.

Three statements in proposal.md that the rest of the stack made false are corrected here too, since the proposal describes the change as a whole:

  • solid-waste disposal adds open and controlled dumps to the existing destinations rather than replacing them — Relleno sanitario, Incineración and Reciclaje all survive with their factors;
  • the migration loads the 157 municipios as well as the regions and provinces;
  • the territorial catalog comes from article 7 of Ley 345-22, not from the ONE, which the stack established while authoring PR 3.

The ISO sweep

The interesting question is whether the sweep is complete. grep -rn '"PD"' tools/seed/src/data/base/ returns nothing, and the 135 replaced occurrences were all countryIsoCode (or isoCode in countries.json) — worth confirming with the same grep.

Verification

pnpm format && pnpm lint && pnpm type-check green. The end-to-end pnpm db:reset + seed run is not verified here (no database available in the authoring environment); it is tracked as task 2.4 and should be exercised alongside the reset window MMARN has to agree to anyway, since seed.ts skips entirely when country.count() > 0.

@mrivas00 mrivas00 added priority: high High priority type: feature new user-facing capability or enhancement area: packages shared packages/* labels Aug 21, 2026
@mrivas00
mrivas00 force-pushed the feat/mati/rd-deployment-identity branch 3 times, most recently from 04338e9 to 873c157 Compare August 26, 2026 12:12
Proposal, design and tasks for the Dominican Republic deployment
adaptation: the ten MMARN observations translated into a linear stack
of eight pull requests on the terminal rd/integration branch.
The base dataset shipped a demo country: MMARN's environment must
identify itself as the deployment it is. Rewrites countries.json and
sweeps countryIsoCode from PD to DO across the six base seed files that
scope their rows by country, so every catalog keeps resolving.

The testing dataset keeps its own País Demo fixture: it is test data,
not deployment data.
@mrivas00
mrivas00 force-pushed the feat/mati/rd-deployment-identity branch from 873c157 to 239b843 Compare August 26, 2026 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: packages shared packages/* priority: high High priority type: feature new user-facing capability or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant