feat(seed): set the deployment country to República Dominicana - #610
Open
mrivas00 wants to merge 2 commits into
Open
feat(seed): set the deployment country to República Dominicana#610mrivas00 wants to merge 2 commits into
mrivas00 wants to merge 2 commits into
Conversation
mrivas00
force-pushed
the
feat/mati/rd-deployment-identity
branch
3 times, most recently
from
August 26, 2026 12:12
04338e9 to
873c157
Compare
Proposal, design and tasks for the Dominican Republic deployment adaptation: the ten MMARN observations translated into a linear stack of eight pull requests on the terminal rd/integration branch.
The base dataset shipped a demo country: MMARN's environment must identify itself as the deployment it is. Rewrites countries.json and sweeps countryIsoCode from PD to DO across the six base seed files that scope their rows by country, so every catalog keeps resolving. The testing dataset keeps its own País Demo fixture: it is test data, not deployment data.
mrivas00
force-pushed
the
feat/mati/rd-deployment-identity
branch
from
August 26, 2026 20:21
873c157 to
239b843
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
MMARN reviewed the test environment and returned ten written observations. The first thing they see is a platform that calls itself "País Demo": the base seed dataset ships a demo country, and every catalog scoped by country hangs off its
PDISO code.This is PR 1 of 8 on the
rd/integrationstack — the long-lived branch RD inherits, which is not merged back into Huella Latam. It goes first because the ISO sweep touches the six seed files that PRs 4, 6 and 8 rewrite; landing it later means those rewrites conflict with it.What
countries.json:País Demo/PD→República Dominicana/DO.countryIsoCodeswept fromPDtoDOacross the six base seed files that scope rows by country: organization sizes, sector/subsectors, methodologies, job positions, main activities and subcategory recommendations (135 occurrences, all of them the country field — no other value in the dataset is"PD").proposal.md,design.md,tasks.md, five capability specs) is committed as the plan for the whole stack.The
testingdataset keeps its ownPaís Demofixture on purpose — it is test data, not deployment data, and API integration tests pin to it.No schema change, no code change: no
.ts/.tsxfile references the ISO code, so the sweep is data-only.Review notes
The change proposes five capabilities, not six. A sixth — an escape-hatch dimension value obliging its capture line to carry a comment — was originally proposed here and withdrawn in PR 8, once it turned out the rule could only match dimension values by name and so could not be scoped to one dimension without becoming a per-dimension rule. It never ships, so it is no longer proposed: a requirement delta in front of a reviewer that no code satisfies is worse than no delta.
Three statements in
proposal.mdthat the rest of the stack made false are corrected here too, since the proposal describes the change as a whole:Relleno sanitario,IncineraciónandReciclajeall survive with their factors;The ISO sweep
The interesting question is whether the sweep is complete.
grep -rn '"PD"' tools/seed/src/data/base/returns nothing, and the 135 replaced occurrences were allcountryIsoCode(orisoCodeincountries.json) — worth confirming with the same grep.Verification
pnpm format && pnpm lint && pnpm type-checkgreen. The end-to-endpnpm db:reset+ seed run is not verified here (no database available in the authoring environment); it is tracked as task 2.4 and should be exercised alongside the reset window MMARN has to agree to anyway, sinceseed.tsskips entirely whencountry.count() > 0.