Skip to content

test and fix encoding 0 as a double in RESP3 #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
und3f merged 1 commit into from
Feb 3, 2026
Merged

test and fix encoding 0 as a double in RESP3 #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/Protocol/Redis.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ sub _encode_resp3 {
# Double
elsif ($message->{type} eq ',') {
# inf
if ($message->{data} == $message->{data} * 2) {
if ($message->{data} != 0 and $message->{data} == $message->{data} * 2) {
$encoded_message .= ',' . ($message->{data} > 0 ? '' : '-') . "inf\r\n";
}
# nan
Expand Down
4 changes: 3 additions & 1 deletion lib/Protocol/Redis/Test.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ sub _apiv3_ok {
my $redis_class = shift;

subtest 'Protocol::Redis APIv3 ok' => sub {
plan tests => 150;
plan tests => 151;

_test_version_3($redis_class);
}
Expand Down Expand Up @@ -841,6 +841,8 @@ sub _encode_v3_ok {
'encode negative double with exponent';
is $redis->encode({type => ',', data => '10'}), ",10\r\n",
'encode integer as double';
is $redis->encode({type => ',', data => '0'}), ",0\r\n",
'encode zero as double';
is $redis->encode({type => ',', data => 9**9**9}), ",inf\r\n",
'encode inf';
is $redis->encode({type => ',', data => -9**9**9}), ",-inf\r\n",
Expand Down
Loading