Skip to content

Add volume flyout sync toggle - #1058

Closed
lgc2333 wants to merge 1 commit into
unchihugo:masterfrom
lgc2333:codex/volume-sync-media-flyout
Closed

Add volume flyout sync toggle#1058
lgc2333 wants to merge 1 commit into
unchihugo:masterfrom
lgc2333:codex/volume-sync-media-flyout

Conversation

@lgc2333

@lgc2333 lgc2333 commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds a volume setting above the volume flyout stay-duration control for linking manual media flyout triggers with the volume flyout.

Taskbar widget and tray "show media flyout" entries now go through a wrapper that:

  • shows media first, then volume, when opening
  • starts the volume hide animation before the media hide animation on toggle-close, without waiting between them

These popups are visually syncing when open btw

Media-key and volume-key paths keep their existing direct calls. Auto stay-duration behavior is still timer-driven, so matching media/volume durations naturally collapse together without extra close synchronization.

image

Motivation

closes #1050

Type of Change

  • Feature

Checklist

  • Code changes are manually tested and working.
  • Formatting and naming are consistent with the project.
  • Self-review of changes is done.
  • AI tools were used (if yes, I reviewed and fully understand the changes myself).

@github-actions github-actions Bot added MainWindow / Media Flyout Changes to MainWindow including the Media Flyout Volume Flyout Changes to the Volume Flyout or Volume Mixer Taskbar Widget Changes to the Taskbar Media Widget labels Aug 23, 2026
@lgc2333
lgc2333 force-pushed the codex/volume-sync-media-flyout branch from 8b94922 to 7596b50 Compare August 23, 2026 14:40
@lgc2333
lgc2333 marked this pull request as ready for review August 23, 2026 14:43
@lgc2333
lgc2333 force-pushed the codex/volume-sync-media-flyout branch from 7596b50 to a92ff7f Compare August 24, 2026 14:09
@lgc2333

lgc2333 commented Aug 24, 2026

Copy link
Copy Markdown
Contributor Author

maybe i should change the title of this configuration item? i think its meaning is too broad. because if the "always display" turned on, or the "stay time" setting is different between these widgets, they will not close at the same time.

only click the taskbar widget will let them close together now.

(sorry about my bad english skill)

@lgc2333
lgc2333 force-pushed the codex/volume-sync-media-flyout branch 5 times, most recently from 8a283f7 to 904536c Compare August 24, 2026 15:07
@lgc2333 lgc2333 mentioned this pull request Aug 27, 2026
5 tasks
@lgc2333
lgc2333 force-pushed the codex/volume-sync-media-flyout branch from 904536c to eee69c3 Compare August 28, 2026 15:36
Co-authored-by: Codex <codex@openai.com>
@lgc2333
lgc2333 force-pushed the codex/volume-sync-media-flyout branch from eee69c3 to 880a231 Compare September 4, 2026 21:40
@lgc2333

lgc2333 commented Sep 8, 2026

Copy link
Copy Markdown
Contributor Author

close due to low possibility merging. issue: #1050

@lgc2333 lgc2333 closed this Sep 8, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

MainWindow / Media Flyout Changes to MainWindow including the Media Flyout Taskbar Widget Changes to the Taskbar Media Widget Volume Flyout Changes to the Volume Flyout or Volume Mixer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] 音量浮窗随任务栏组件或托盘图标的点击而一并弹出

1 participant