Skip to content

Fix taskbar updates for synced lyrics - #1027

Open
puohecbhad-bit wants to merge 4 commits into
unchihugo:masterfrom
puohecbhad-bit:agent/fix-synced-lyrics-taskbar-updates
Open

Fix taskbar updates for synced lyrics#1027
puohecbhad-bit wants to merge 4 commits into
unchihugo:masterfrom
puohecbhad-bit:agent/fix-synced-lyrics-taskbar-updates

Conversation

@puohecbhad-bit

Copy link
Copy Markdown

Summary

  • recognize SMTC bridges that publish synced lyrics through Title while preserving the original title - artist identity in Artist
  • animate only the title for lyric updates and keep the taskbar widget layout, artwork, controls, and Next Up behavior tied to real track changes
  • cache artwork work across lyric/playback updates and retry briefly after track changes when a bridge publishes the final thumbnail late without another media-property event

Why

Some SMTC lyric bridges replace the title for every lyric line and create fresh thumbnail references even when the artwork is unchanged. Treating every event as a new song caused the whole taskbar widget to re-enter, repeatedly decoded artwork, and showed Next Up for lyric lines. In addition, some bridges expose the new track before its final cover and do not always raise another event when the cover becomes available.

Validation

  • built the GitHub Release|x64 MSIX bundle successfully (0 errors)
  • manually tested with an SMTC bridge that updates the title for synced lyrics
  • verified lyric lines only animate the title, artwork and controls remain stable, Next Up only appears for real tracks, and delayed artwork catches up after track changes

@github-actions github-actions Bot added MainWindow / Media Flyout Changes to MainWindow including the Media Flyout TaskbarWindow Changes to TaskbarWindow; the container for taskbar widgets Taskbar Widget Changes to the Taskbar Media Widget labels Aug 15, 2026
@puohecbhad-bit
puohecbhad-bit marked this pull request as ready for review August 15, 2026 08:48
@puohecbhad-bit
puohecbhad-bit marked this pull request as draft August 15, 2026 08:49
@puohecbhad-bit
puohecbhad-bit marked this pull request as ready for review August 15, 2026 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

MainWindow / Media Flyout Changes to MainWindow including the Media Flyout Taskbar Widget Changes to the Taskbar Media Widget TaskbarWindow Changes to TaskbarWindow; the container for taskbar widgets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant