feat: profile-axis plugin layers, PATH baseline for non-login shells - #104
Merged
Conversation
Only login shells run /etc/zprofile's path_helper; agent harnesses and zsh -c inherited whatever PATH the parent had, which dropped /usr/bin on this workstation mid-session. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Layers are now named for the profile axes (shared, workstation, devbox, personal) and profiles compose them; identical entries selected by more than one axis install once. ffsstack ships on workstation and personal layers, so personal machines and the work workstation get it while the plain devbox does not. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This pull request fixes missing system binaries in non-login zsh processes by establishing a lowest-precedence PATH baseline in .zshenv, and refactors agent skill/plugin layering to align with profile “axes” (shared/workstation/devbox/personal) so profiles compose layers and identical selections can collapse to a single install.
Changes:
- Append core system directories to PATH (lowest precedence) for all zsh processes via
chezmoi/dot_zshenv. - Rename/expand agent skill + plugin layers to
shared/workstation/devbox/personaland update profile model + docs accordingly. - Adjust agent sync logic and tests to support composed layers and collapsing identical selections; move
ffsstackto workstation + personal plugin layers.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| scripts/verify/vendor-neutral.sh | Updates vendor-neutral allowlist patterns for the new skill/plugin manifest layer files. |
| scripts/profiles/model.ts | Expands the allowed skillLayers set/type to include workstation and devbox axes. |
| scripts/agents/sync.ts | Reads additional skill layers and collapses duplicate skill selections across composed layers. |
| scripts/agents/sync.test.ts | Updates fixtures and assertions for the new layer composition behavior. |
| scripts/agents/skills/workstation.json | Adds an (empty) workstation skill layer manifest. |
| scripts/agents/skills/devbox.json | Adds an (empty) devbox skill layer manifest. |
| scripts/agents/plugins/workstation.json | Adds workstation plugin layer and ships ffsstack there. |
| scripts/agents/plugins/devbox.json | Adds an (empty) devbox plugin layer manifest. |
| scripts/agents/plugins.ts | Reads additional plugin layers and collapses identical plugin selections across composed layers. |
| scripts/agents/plugins.test.ts | Extends tests for new layer composition and ffsstack placement across layers. |
| docs/agents.md | Documents the new axis-based layering model and composition rules. |
| chezmoi/dot_zshenv | Adds a PATH baseline for non-login shells (agent harnesses, zsh -c, etc.). |
| chezmoi/.chezmoidata/profiles.json | Updates profiles to compose the new skill layer axes (workstation/devbox/personal). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Cross-layer composition still collapses identical entries; a duplicate inside a single manifest file is an authoring error and fails closed. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Agent harness shells lost
/usr/binafter a dotfiles apply because only login shells run path_helper. The ffsstack plugin lived on the personal layer while the work workstation also needs it, and layer names ("shared", "coding") did not match how profiles actually compose.Solution
.zshenvappends the system directories as the lowest-precedence PATH baseline and exports it, covering shells that started with no PATH at all.{developer,workstation,devbox,personal}.json. "shared" was never shared beyond developer machines, andruntimeGroup: developeralready names that set. Profiles compose their axes; identical entries across axes install once; duplicates inside one manifest fail closed.Proof
The broken state reproduced as a harness shell whose PATH was homebrew + android only; with the exported baseline,
env -i HOME=$HOME /bin/zsh -c 'command -v sed'resolves.🤖 Generated with Claude Code