ci: cut unchanged verification to 3.3 seconds - #22
Conversation
There was a problem hiding this comment.
⚡ SLOPS ZAPPED: 1
Verdict: Zaps needed
Folding Release into Main changes the OIDC workflow filename npm checks, so Trusted Publishing no longer matches the registered release.yml publisher and CLI publishes fail closed. The Vite task-cache wiring is not a second proved break.
Findings
- 🧨 MIDSLOP · P1 — Release caller is now main.yml — npm trusted-publisher match is bogus (
.github/workflows/main.yml:89)
There was a problem hiding this comment.
Pull request overview
This PR restructures repo verification and delivery around a repository-owned Vite Task graph and reuses that graph across local scripts and CI, aiming to avoid re-running unchanged lanes and to ensure main verification gates deploy/release.
Changes:
- Introduces a top-level Vite Task graph (
ready,checks,tests,builds, etc.) with explicit dependencies to parallelize verification work. - Refactors root and
apps/apiscripts to route through the new task graph (including Worker build/test tasks with declared inputs/outputs). - Updates CI workflows to restore the Vite Task cache and makes the release workflow reusable and gated by the main workflow’s verify/scan jobs.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
vite.config.ts |
Adds repo-level Vite Task graph to coordinate checks/tests/builds/types with dependencies. |
package.json |
Simplifies check/test/build to run the new task graph targets. |
CONTRIBUTING.md |
Documents the new verification flow and the no-cache “force every lane” option. |
apps/api/vite.config.ts |
Defines cacheable Worker build/test tasks with explicit inputs/outputs. |
apps/api/package.json |
Routes API build/test scripts through the new Vite Task tasks. |
AGENTS.md |
Updates contributor guidance around cached verification and forcing full runs. |
.github/workflows/verify.yml |
Restores the Vite Task cache before running the canonical ready gate. |
.github/workflows/release.yml |
Converts release workflow to workflow_call and removes duplicated verify/scan. |
.github/workflows/main.yml |
Restores the Vite Task cache, gates deploy/release on verify+scan, and calls reusable release workflow. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
⚡ SLOPS ZAPPED: 1
Verdict: Zaps needed
Calling release.yml via workflow_call makes npm OIDC authenticate as main.yml. The registered trusted publisher is still release.yml, so CLI publishes will fail until that match is restored.
Findings
- 🧨 MIDSLOP · P1 — npm trusted publisher still release.yml — workflow_call publish auth is broken (
.github/workflows/release.yml:9)
|
@slopzapper re-review |
|
A review is already running for head |
Local and CI verification serialized independent monorepo lanes, and a main push repeated the same full verify and scan in the release workflow.
actionlintandzizmorreport no findings.