fix: replace geo input assert with ValueError and add test - #502
Open
dyrpsf wants to merge 3 commits into
Open
Conversation
Contributor
Author
|
I noticed the |
Contributor
Author
|
I've resolved the merge conflicts and fixed the CI linter error! Just to recap: it looks like the The tests should be completely green now and ready for review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves a lingering
todocomment insrc/h3/_h3shape.py.The
geo_to_h3shapefunction contained a debug assertion (assert isinstance(geo, dict) # todo: remove) that was explicitly marked for removal.To improve robustness, I replaced the raw assertion with a proper
ValueErrorcheck to prevent confusingTypeErrorcrashes if a user accidentally passes a string. I also added a unit test totest_polyfill.pyto ensure this specific bad input is caught correctly.Maintainers
cc: @dfellis @ajfriend @isaacbrodsky