Raise ValueError instead of assert in geo_to_h3shape - #500
Merged
jongbinjung merged 1 commit intoAug 24, 2026
Merged
Conversation
The leftover assert isinstance check tripped Bandit and was marked for removal. Invalid inputs now get an explicit ValueError.
isaacbrodsky
requested review from
ajfriend,
dfellis,
isaacbrodsky and
jongbinjung
August 23, 2026 18:23
jongbinjung
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
geo_to_h3shape still used assert isinstance(geo, dict), which Bandit flags and which was already marked for removal.
This raises ValueError for invalid inputs instead, matching nearby validation style, and adds a unit test for the rejection path.
Fixes #498
Test plan