Skip to content

test: add test for uncompacting to a coarser resolution #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jongbinjung merged 3 commits into from
Aug 14, 2026
+10 −2
Merged

test: add test for uncompacting to a coarser resolution #497

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2f62194
test: add test for uncompacting cells to a coarser resolution
dyrpsf Jul 28, 2026
58be699
Update tests/test_lib/test_cells_and_edges.py
dyrpsf Aug 1, 2026
5dc46e4
test: update comment to match H3ResMismatchError
dyrpsf Aug 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/h3/api/basic_int/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,8 +474,6 @@ def uncompact_cells(cells, res):
-----
There is currently no guaranteed order of the output cells.
"""
# TODO: add test to make sure an error is returned when input contains cell
# smaller than output res.

hc = _in_collection(cells)
hu = _cy.uncompact_cells(hc, res)
Expand Down
10 changes: 10 additions & 0 deletions tests/test_lib/test_cells_and_edges.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -755,3 +755,13 @@ def test_construct_cell_inverses_int_api():
def test_center_child_with_deconstruct():
for h in h3.get_res0_cells():
h3.construct_cell(*h3.deconstruct_cell(h), 0) == h3.cell_to_center_child(h)


def test_uncompact_cells_invalid_resolution():
# Create a valid cell at resolution 5
h_res5 = h3.latlng_to_cell(0, 0, 5)

# Attempting to uncompact to a coarser resolution (4)
# should raise an H3ResMismatchError
with pytest.raises(H3ResMismatchError):
h3.uncompact_cells({h_res5}, 4)
Loading