Skip to content

test: clean up string formatting TODO in test_parent_err #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
isaacbrodsky merged 3 commits into from
Aug 3, 2026
+1 −3
Merged

test: clean up string formatting TODO in test_parent_err #496

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
497aa4d
test: clean up string formatting in test_parent_err
dyrpsf Jul 26, 2026
8cd64de
Update tests/test_lib/test_cells_and_edges.py
dyrpsf Aug 1, 2026
822320f
test: restore 0x prefix to match actual exception message
dyrpsf Aug 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions tests/test_lib/test_cells_and_edges.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,9 +131,7 @@ def test_parent_err():
except Exception as e:
msg = str(e)

# todo: revist this weird formatting stuff
expected = 'Invalid parent resolution -1 for cell {}.'
expected = expected.format(hex(h3.str_to_int(h)))
expected = f'Invalid parent resolution -1 for cell 0x{h}.'

assert msg == expected

Expand Down
Loading