Preserve aliased imports when parsing embedded interface packages - #311
Open
hdimer wants to merge 1 commit into
Open
Preserve aliased imports when parsing embedded interface packages#311hdimer wants to merge 1 commit into
hdimer wants to merge 1 commit into
Conversation
In source mode, parsePackage collected an imported package's imports from ast.MergePackageFiles(..., FilterImportDuplicates). That filter dedupes imports by path, so when one file imports a package plainly and another file aliases it, the alias is dropped and later references to it fail with "unknown package". Read imports from each file instead of the merged file so aliases survive. Interface discovery still uses the merged file. Fixes uber-go#254
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #254.
In source mode,
parsePackagecollected an imported package's imports fromast.MergePackageFiles(..., FilterImportDuplicates). That filter dedupes imports by path, so when one file imports a package plainly and another file aliases it, the alias is dropped and later references fail withunknown package "<alias>".Read imports from each file instead of the merged file so aliases survive. Interface discovery still uses the merged file. Added a regression test (
aliased_embedded_interfacefixture) reproducing the reported failure.Used AI assistance on this; I reviewed and tested it.