Skip to content

mockgen: format generated code without invoking go #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
podtserkovskiy wants to merge 1 commit into
base: main
Choose a base branch
from
Open

mockgen: format generated code without invoking go #310

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion mockgen/mockgen.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -874,7 +874,15 @@ func (o identifierAllocator) allocateIdentifier(want string) string {

// Output returns the generator's output, formatted in the standard Go style.
func (g *generator) Output() []byte {
src, err := toolsimports.Process(g.destination, g.buf.Bytes(), nil)
// FormatOnly keeps formatting hermetic: mockgen already emits a complete,
// self-consistent import set, so goimports' add/remove pass (which shells
// out to `go` and breaks in Buck/Bazel) is unnecessary.
src, err := toolsimports.Process(g.destination, g.buf.Bytes(), &toolsimports.Options{
Comments: true,
TabIndent: true,
TabWidth: 8,
FormatOnly: true,
})
if err != nil {
log.Fatalf("Failed to format generated source code: %s\n%s", err, g.buf.String())
}
Expand Down