Added test + fixes + URC queue optimization by ante-ublox · Pull Request #46 · u-blox/u-connectClient

ante-ublox · 2026-09-07T12:24:00Z

No description provided.

Prevent Ceedling from adding every STM32Cube directory to compiler include paths, which can exceed the system argument length limit.

Defer direct URC callbacks until framing determines whether binary data follows. Report the preserved URC line length after parser state resets.

Cover fragmented binary data, timeouts, I/O failures, parser recovery, response APIs, and interleaved URCs. Require URC callbacks to run and validate binary payload delivery with and without the URC queue.

Migrate the project configuration to Ceedling 1 syntax and plugins. Install the same Ceedling release in the STM32 build image and pin a compatible gcovr version for coverage reports.

Do not dequeue URCs while a fragmented binary URC still owns the enqueue mutex. Process the queue once reception completes.

Split binary URC headers and payloads across separate receive calls with and without the URC queue. Also fragment the response discard path when the caller's binary buffer is too small.

Store partial binary length bytes in the client receive state instead of a shared static buffer. This prevents interleaved clients from corrupting each other's binary frame lengths.

Interleave partial headers from two clients with different nonzero length bytes. Verify each client retains its own header before receiving the remaining payload.

Store direct URC payload data after the string terminator instead of overwriting it. Accept payloads that exactly fill the available direct or queued URC buffer.

Cover partial-header failures, zero-length frames, exact-fit buffers, opaque control bytes, oversized payload discard, and subsequent parser recovery with and without the URC queue.

Cover UART argument validation, reopen behavior, and background RX work. Fix the test fixture buffers so ring-buffer overflow checks remain bounded.

Hold the command mutex while closing the UART and checking whether background receive work may run. This prevents queued work from reading a UART after another thread closes it. Unwind intentionally incomplete commands in unit-test teardown before closing the client.

Drive command responses and URCs through the UART emulator, ISR, and background RX worker. Cover fragmented text and binary responses, fragmented binary URCs, timeout recovery, and immediate teardown.

Do not retain mutex ownership while a fragmented binary URC waits for more payload. Hide incomplete entries from dequeueing so another thread can safely abort the transaction when a receive session closes.

Serialize open with close and background RX. Clear partial parser and binary response state at session boundaries, and abort an incomplete queued binary URC before starting the next UART session.

Inject device initialization, UART configuration, and callback setup failures and verify a valid reopen after each one. Exercise repeated commands, text and binary URCs, close/reopen cycles, and interrupted binary payloads in regular and opt-in soak scenarios.

Support 1, 1.5, 2, and 3 Mbaud termios mappings used during module baud-rate negotiation.

Use poll() for nonblocking, timed, and blocking reads. Retry interrupted poll and read calls, and reject zero-progress writes to avoid an unbounded loop.

Skip receive handling while the client is closed and retry transient receive failures instead of terminating the process. Track successful thread creation so teardown never joins an invalid thread, and release pthread attributes after setup.

Exercise Linux UART configuration, binary transfers, timeout behavior, fault handling, and repeated open/close using pseudoterminals. Run the suite with sanitizers and gcov through inv test.posix.run.

Disable the UART peripheral clock when HAL initialization fails so a failed open does not leave hardware resources enabled.

Fail UART open and release initialized resources when the first interrupt-driven receive operation cannot be armed.

Split writes at the HAL transfer-size limit instead of truncating the requested length to 16 bits.

Treat negative read timeouts as infinite waits as documented, while retaining finite timeout and nonblocking behavior.

Reject duplicate RX task creation and let the task clear its own handle before deletion. Wait on that handle during teardown to avoid querying a failed or already deleted task.

Exercise the STM32 UART and FreeRTOS ports with host HAL and RTOS shims, including failure injection, fragmentation, overflow, timeout, large transfers, and repeated task lifecycle tests. Add Invoke tasks for sanitizer, coverage, and Renode integration runs.

Track initialization separately from the boot tick and calculate elapsed time with unsigned arithmetic. This avoids epoch resets at tick zero and negative elapsed times when the platform timer wraps.

Exercise initialization, timer rollover, busy-wait sleep, mutex state, and background RX stubs with a deterministic host clock. Add sanitizer and coverage execution through the test.no-os Invoke namespace and keep the standalone suite out of Ceedling discovery.

Start receive workers only while a client is open and wake them from UART readiness events instead of polling every 10 milliseconds. Keep command reads timed. Event-driven workers drain only bytes that are immediately available.

Verify idle workers remain blocked, UART input wakes them, and shutdown cancels pending waits across POSIX and FreeRTOS host tests.

Keep variable-length URC entries in circular storage so dequeue can advance a cursor instead of moving every remaining entry. Preserve contiguous binary payload buffers and align entry headers for targets that require halfword-aligned access.

Cover wrapped FIFO ordering, binary payload continuity, abort recovery, exact-capacity entries, alignment, sustained reuse, and full queues.

Add POSIX, no-OS, and STM32 host tests to a native test matrix. Run both Renode examples and align Ceedling with the project version. Keep the regular Zephyr suite in pull requests while excluding its long-running stress configuration.

Use explicit wrap state when calculating contiguous payload space so an entry ending at the read cursor cannot overwrite unread queue data.

Snapshot binary receive state under the command mutex before deciding whether queued URCs can be delivered outside the lock.

Verify that an entry filling the wrapped head reports no remaining binary payload space.

Compile the real Windows OS and UART ports against deterministic Win32 fakes. Cover COM configuration, I/O faults, event waits, and RX worker lifecycle.

Expose the Windows host suite through Invoke and execute it with MSVC on the native Windows pull request runner.

Exclude native Windows tests from Ceedling and namespace mocked Win32 symbols so they do not conflict with kernel32.lib. Use one writable ccache directory for every STM32 Docker step.

ubx-cmag

It's almost impossible to review this many files, but I have merged them to my matter branch and it seem to work well, lets merge this and fix later if anything new is found.

On STM32H7 I got 1.25 Mbit/s with HTTP download and 880 kbits/s with HTTPS (TLS)

ante-ublox added 30 commits September 5, 2026 20:10

project.yml: Exclude STM32 vendor tree from unit tests

f263132

Prevent Ceedling from adding every STM32Cube directory to compiler include paths, which can exceed the system argument length limit.

u_cx_at_client: Fix binary URCs without queue

9146298

Defer direct URC callbacks until framing determines whether binary data follows. Report the preserved URC line length after parser state resets.

test: Expand AT client coverage

039b4f1

Cover fragmented binary data, timeouts, I/O failures, parser recovery, response APIs, and interleaved URCs. Require URC callbacks to run and validate binary payload delivery with and without the URC queue.

build: Update unit tests to Ceedling 1.0.1

13c87a6

Migrate the project configuration to Ceedling 1 syntax and plugins. Install the same Ceedling release in the STM32 build image and pin a compatible gcovr version for coverage reports.

u_cx_at_client: Defer URC processing during binary RX

91f861f

Do not dequeue URCs while a fragmented binary URC still owns the enqueue mutex. Process the queue once reception completes.

test: Cover fragmented binary receive stages

641af68

Split binary URC headers and payloads across separate receive calls with and without the URC queue. Also fragment the response discard path when the caller's binary buffer is too small.

u_cx_at_client: Preserve binary header per client

0474ce7

Store partial binary length bytes in the client receive state instead of a shared static buffer. This prevents interleaved clients from corrupting each other's binary frame lengths.

test: Cover interleaved fragmented binary headers

4f4e3ef

Interleave partial headers from two clients with different nonzero length bytes. Verify each client retains its own header before receiving the remaining payload.

u_cx_at_client: Preserve binary URC line terminator

924c6bd

Store direct URC payload data after the string terminator instead of overwriting it. Accept payloads that exactly fill the available direct or queued URC buffer.

test: Expand binary receive boundary coverage

8a2a24b

Cover partial-header failures, zero-length frames, exact-fit buffers, opaque control bytes, oversized payload discard, and subsequent parser recovery with and without the URC queue.

test: Expand Zephyr port coverage

d5a299c

Cover UART argument validation, reopen behavior, and background RX work. Fix the test fixture buffers so ring-buffer overflow checks remain bounded.

test: Add Zephyr client integration coverage

d611428

Drive command responses and URCs through the UART emulator, ISR, and background RX worker. Cover fragmented text and binary responses, fragmented binary URCs, timeout recovery, and immediate teardown.

u_cx_at_urc_queue: Release lock between fragments

2ae44dd

Do not retain mutex ownership while a fragmented binary URC waits for more payload. Hide incomplete entries from dequeueing so another thread can safely abort the transaction when a receive session closes.

u_cx_at_client: Reset receive state on reopen

4d2eec5

Serialize open with close and background RX. Clear partial parser and binary response state at session boundaries, and abort an incomplete queued binary URC before starting the next UART session.

u_port_uart_linux: Add high-speed baud rates

dd9a8ea

Support 1, 1.5, 2, and 3 Mbaud termios mappings used during module baud-rate negotiation.

u_port_uart_linux: Honor read timeouts

09799d6

Use poll() for nonblocking, timed, and blocking reads. Retry interrupted poll and read calls, and reject zero-progress writes to avoid an unbounded loop.

test: Add native POSIX port coverage

5a231a0

Exercise Linux UART configuration, binary transfers, timeout behavior, fault handling, and repeated open/close using pseudoterminals. Run the suite with sanitizers and gcov through inv test.posix.run.

u_port_uart_stm32f4: Disable clock after init failure

880d167

Disable the UART peripheral clock when HAL initialization fails so a failed open does not leave hardware resources enabled.

u_port_uart_stm32f4: Check receive startup

5996e76

Fail UART open and release initialized resources when the first interrupt-driven receive operation cannot be armed.

u_port_uart_stm32f4: Chunk large writes

b5713ad

Split writes at the HAL transfer-size limit instead of truncating the requested length to 16 bits.

u_port_uart_stm32f4: Support blocking reads

33c4c86

Treat negative read timeouts as infinite waits as documented, while retaining finite timeout and nonblocking behavior.

u_port_freertos: Harden RX task lifecycle

9f9b790

Reject duplicate RX task creation and let the task clear its own handle before deletion. Wait on that handle during teardown to avoid querying a failed or already deleted task.

u_port_no_os: Make timing wrap-safe

37288fd

Track initialization separately from the boot tick and calculate elapsed time with unsigned arithmetic. This avoids epoch resets at tick zero and negative elapsed times when the platform timer wraps.

ports: Wake RX workers from UART events

4d05d9e

Start receive workers only while a client is open and wake them from UART readiness events instead of polling every 10 milliseconds. Keep command reads timed. Event-driven workers drain only bytes that are immediately available.

test: Cover event-driven RX workers

b46a7e7

Verify idle workers remain blocked, UART input wakes them, and shutdown cancels pending waits across POSIX and FreeRTOS host tests.

ante-ublox added 8 commits September 6, 2026 11:44

u_cx_at_urc_queue: Use circular storage

d7f0133

Keep variable-length URC entries in circular storage so dequeue can advance a cursor instead of moving every remaining entry. Preserve contiguous binary payload buffers and align entry headers for targets that require halfword-aligned access.

test: Cover circular URC queue reuse

7521ebd

Cover wrapped FIFO ordering, binary payload continuity, abort recovery, exact-capacity entries, alignment, sustained reuse, and full queues.

ci: Run port tests in pull requests

e1933e4

Add POSIX, no-OS, and STM32 host tests to a native test matrix. Run both Renode examples and align Ceedling with the project version. Keep the regular Zephyr suite in pull requests while excluding its long-running stress configuration.

u_cx_at_urc_queue: Bound wrapped payload capacity

e01e535

Use explicit wrap state when calculating contiguous payload space so an entry ending at the read cursor cannot overwrite unread queue data.

u_cx_at_client: Synchronize binary RX state check

53408c5

Snapshot binary receive state under the command mutex before deciding whether queued URCs can be delivered outside the lock.

test: Cover full wrapped payload capacity

009c9f5

Verify that an entry filling the wrapped head reports no remaining binary payload space.

test: Add Windows port coverage

a85d7f4

Compile the real Windows OS and UART ports against deterministic Win32 fakes. Cover COM configuration, I/O faults, event waits, and RX worker lifecycle.

ci: Run Windows port tests

af2eeba

Expose the Windows host suite through Invoke and execute it with MSVC on the native Windows pull request runner.

ante-ublox requested review from henningrehn, magnushanssonublox and ubx-cmag September 7, 2026 12:24

ante-ublox self-assigned this Sep 7, 2026

ci: Fix Windows tests and STM32 cache setup

ab5e7a8

Exclude native Windows tests from Ceedling and namespace mocked Win32 symbols so they do not conflict with kernel32.lib. Use one writable ccache directory for every STM32 Docker step.

ante-ublox force-pushed the anan_fixes branch from 231ff9f to ab5e7a8 Compare September 7, 2026 14:03

ubx-cmag approved these changes Sep 8, 2026

View reviewed changes

ante-ublox merged commit e830983 into master Sep 9, 2026
9 checks passed

Navigation Menu

Added test + fixes + URC queue optimization - #46

Added test + fixes + URC queue optimization#46
ante-ublox merged 39 commits into
masterfrom
anan_fixes

ante-ublox commented Sep 7, 2026

Uh oh!

ubx-cmag left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

ante-ublox commented Sep 7, 2026

Uh oh!

ubx-cmag left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants