Skip to content

fix(invoices): let the quantity field actually clear instead of snapping back to 0 #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tyrellcurry merged 1 commit into from
Aug 8, 2026
Merged

fix(invoices): let the quantity field actually clear instead of snapping back to 0 #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions frontend/e2e/create-invoice.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,20 @@ test('a new item starts with a blank price, not a literal 0', async ({ page }) =
await expect(page.locator('[id^="item-price-"]:visible')).toHaveValue('');
});

test('clearing the quantity field leaves it empty, not stuck on 0', async ({ page }) => {
await page.goto('/');

await page.getByRole('button', { name: 'New Invoice' }).click();
await visibleButton(page, '+ Add New Item').click();

const qty = page.locator('[id^="item-qty-"]:visible');
await expect(qty).toHaveValue('1');

await qty.fill('');

await expect(qty).toHaveValue('');
});

test('shows the save error inside the still-open drawer, not on the page', async ({ page }) => {
await page.goto('/');

Expand Down
7 changes: 6 additions & 1 deletion frontend/src/features/invoices/components/invoice-form-drawer/invoice-form-drawer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,12 @@ const InvoiceFormDrawer = (props: IInvoiceFormDrawerProps): JSX.Element => {
id={`item-qty-${index}`}
min={0}
type="number"
value={item.quantity}
// Backspacing to empty fires onChange with '', and
// Number('') is 0, not NaN, so without this the
// controlled value snaps straight back to a literal
// "0" and the field never visibly clears. Same fix
// already used for price, below.
value={item.quantity || ''}
// appearance-none drops the spinner in Firefox and
// current Chrome/Safari; the two arbitrary-variant
// rules clear WebKit's older spin-button pseudo
Expand Down
Loading