Repository navigation
feat: add RenderOptions render entry points and support CRLF line endings - #18
Merged
Merged
Conversation
There was no place to put rendering configuration beyond `width`, so each new control would need its own method family. Existing `render`, `render_fmt`, `render_raw`, and `print` keep their signatures and delegate with `RenderOptions::new(width)`; output is unchanged.
The terminator was hardcoded to "\n", so callers emitting CRLF had to post-process the whole output, which also rewrites newlines embedded in text payloads. `LineEnding` now selects the terminator for structural breaks only; embedded text newlines pass through verbatim, and terminator length never affects fitting or column accounting. LF stays the default on every platform, with no system detection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was no place to put rendering configuration beyond
width, soeach new control would need its own method family. Existing
render,render_fmt,render_raw, andprintkeep their signatures anddelegate with
RenderOptions::new(width); output is unchanged.The terminator was hardcoded to "\n", so callers emitting CRLF had to
post-process the whole output, which also rewrites newlines embedded
in text payloads.
LineEndingnow selects the terminator forstructural breaks only; embedded text newlines pass through verbatim,
and terminator length never affects fitting or column accounting.
LF stays the default on every platform, with no system detection.