Conversation
rjyunis
marked this pull request as draft
August 3, 2026 08:09
Contributor
Author
|
changing this to a draft for the moment. |
Contributor
Author
|
I'm going to close this PR because it still doesn't seem to always solve the problem, and I don't want to change this logic until I have something that works. I'll open an issue and assign it to myself in the meantime. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, it's me again
With the new defined fluid mass method for slosh in Simcenter (NX) Nastran, the old method of determining the number of rigid body modes was incorrectly flagging some slosh modes as rigid. This small change updates the logic to look for eigenvalues, a.k.a. lambda, less than 1. In my testing on real-world models, this works for fixed and free-free structures with slosh.