Skip to content

Short-circuit getcoordinates() in simple cases #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
twmacro merged 2 commits into from
Jul 25, 2026
Merged

Short-circuit getcoordinates() in simple cases #54

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
601c14b
Short-circuit getcoordinates() in simple cases. Significantly faster …
Jul 24, 2026
1ffdd48
correct dimensions for returned array if one gid
Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions pyyeti/nastran/n2p.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2370,6 +2370,12 @@ def getcoordinates(uset, gid, csys, coordref=None):
else: # user passed in a higher dimension array
raise ValueError(f"`gid` is more than 2d (it has {gid.ndim} dimensions)")

# Faster vectorized lookup for simple requests
if isgrid and np.size(csys) == 1 and csys == 0:
idx = [(g, 1) for g in gid]
result = uset.loc[idx, "x":"z"].values
return result if len(gid) > 1 else result[0]

result = []
T = None
for igid in gid:
Expand Down
Loading