fix(azure_postgresql_flexible_server): skip configurations hydrate when server is Stopping/Stopped/Updating - #1015
Open
hakuno wants to merge 1 commit into
Conversation
…tions hydrate when server is Stopping/Stopped/Updating Mirrors the existing guard in listMySQLFlexibleServersConfigurations. Azure rejects GET .../configurations with 400 ServerStoppedError while the flexible server is not Ready, aborting the whole table scan instead of just the row.
hakuno
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
azure_postgresql_flexible_server'sflexible_server_configurationscolumn hydrates vialistPostgreSQLFlexibleServersConfigurations, which calls theConfigurationsClient.NewListByServerPagerAPI unconditionally. When the flexible server is in aStopped(orStopping/Updating) state, Azure rejects this call with a400 ServerStoppedError, which aborts the entire table scan instead of just that row/column.azure_mysql_flexible_server's equivalent hydrate (listMySQLFlexibleServersConfigurations) already guards against this for MySQL (Azure returns409 ServerUnavailableForOperationthere) by skipping the API call whenserver.Properties.StateisStopping,Stopped, orUpdating. This PR applies the same guard to the PostgreSQL flexible server table.Change
slicesimport.listPostgreSQLFlexibleServersConfigurations, returnnil, nilearly whenserver.Properties.Stateis one ofStopping,Stopped,Updating, before calling the Configurations API - mirroring the existing MySQL pattern.Notes
go build ./azure/...on this branch (based on current upstreammain).