Repository navigation
docs: PR作成前のコードレビュー実行をルール化 - #86
Merged
Merged
Conversation
gh pr create の前に code-review スキル(または claude ultrareview)を 必ず実行する運用ルールをCLAUDE.mdに追記。当初はPreToolUseフックでの 自動化を検討したが、if条件付きフック(agent/command両タイプ)が 無関係なBashコマンドまで誤ってブロックする不具合が確認されたため、 フックではなく運用ルールとして明文化する方針にした。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gh pr createの前に code-review スキル(またはclaude ultrareview)を必ず実行する運用ルールをCLAUDE.mdに追記背景
PreToolUseフックでの自動化(
if: "Bash(gh pr create*)"によるagent/commandフック)を検討・実装したが、以下の不具合が確認されたため見送った。git addやgit logなど無関係なBashコマンドまで誤ってブロックされるcdがフックのカレントディレクトリに反映されず、対象リポジトリの特定が不安定になるそのため、フックではなく運用ルールとしてCLAUDE.mdに明文化する方針にした。
Test plan