Feature/analyzers v1 diagnostics

.github/workflows/perf-gate.yml

@@ -97,7 +97,7 @@ jobs:
             --configuration Release \
             --no-build \
             -- \
-            --filter '*Scroll*' '*Config*' '*Scheme*' '*Theme*' \
+            --filter '*Scroll*' '*Config*' '*Scheme*' '*Theme*' '*OutputWriteBenchmark*' '*UnixRawOutputBenchmark*' \
             --job short \
             --exporters json \
             --artifacts ./BenchmarkResults

.gitignore

@@ -91,3 +91,9 @@ artifacts/
 docfx/artifacts/
 local_packages/
 *.cast
+
+# Graphic memory & plan markdown files
+GRAPHIC_MEMORY.md
+plans/
+*.skill.md
+

Directory.Packages.props

@@ -4,7 +4,9 @@
   </PropertyGroup>
   <ItemGroup>
     <!-- Enable Nuget Source Link for github -->
-    <PackageVersion Include="Microsoft.CodeAnalysis.Analyzers" Version="5.9.0" />
+    <PackageVersion Include="Microsoft.CodeAnalysis.Analyzers" Version="3.11.0" />
+    <PackageVersion Include="Microsoft.CodeAnalysis.CSharp.Analyzer.Testing" Version="1.1.2" />
+    <PackageVersion Include="Microsoft.CodeAnalysis.CSharp.CodeFix.Testing" Version="1.1.2" />
     <PackageVersion Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.14.0" />
     <PackageVersion Include="Microsoft.CodeAnalysis.VisualBasic.Workspaces" Version="4.14.0" />
     <PackageVersion Include="Microsoft.CodeAnalysis.Workspaces.MSBuild" Version="4.14.0" />
@@ -13,21 +15,22 @@
     <PackageVersion Include="Microsoft.SourceLink.GitHub" Version="10.0.203" />
     <PackageVersion Include="Microsoft.CodeAnalysis" Version="4.14.0" />
     <PackageVersion Include="Microsoft.CodeAnalysis.Common" Version="4.14.0" />
-    <PackageVersion Include="Microsoft.CodeAnalysis.CSharp" Version="5.9.0" />
-    <PackageVersion Include="Microsoft.Extensions.Configuration" Version="10.0.11" />
-    <PackageVersion Include="Microsoft.Extensions.Configuration.Binder" Version="10.0.11" />
-    <PackageVersion Include="Microsoft.Extensions.Configuration.Json" Version="10.0.11" />
-    <PackageVersion Include="Microsoft.Extensions.Options" Version="10.0.11" />
+    <PackageVersion Include="Microsoft.CodeAnalysis.CSharp" Version="4.14.0" />
+
+    <PackageVersion Include="Microsoft.Extensions.Configuration" Version="10.0.12" />
+    <PackageVersion Include="Microsoft.Extensions.Configuration.Binder" Version="10.0.12" />
+    <PackageVersion Include="Microsoft.Extensions.Configuration.Json" Version="10.0.12" />
+    <PackageVersion Include="Microsoft.Extensions.Options" Version="10.0.12" />
     <PackageVersion Include="Microsoft.Extensions.Logging.Abstractions" Version="10.0.7" />
     <PackageVersion Include="Microsoft.Extensions.Logging" Version="10.0.7" />
     <PackageVersion Include="Microsoft.Extensions.DependencyInjection" Version="10.0.7" />
     <PackageVersion Include="Microsoft.VisualStudio.Azure.Containers.Tools.Targets" Version="1.23.0" />
-    <PackageVersion Include="Microsoft.NET.Test.Sdk" Version="18.9.0" />
+    <PackageVersion Include="Microsoft.NET.Test.Sdk" Version="18.10.1" />
     <PackageVersion Include="Spectre.Console" Version="0.57.2" />
-    <PackageVersion Include="TestableIO.System.IO.Abstractions.TestingHelpers" Version="22.2.0" />
+    <PackageVersion Include="TestableIO.System.IO.Abstractions.TestingHelpers" Version="22.3.0" />
     <PackageVersion Include="xunit.runner.visualstudio" Version="4.0.0" />
-    <PackageVersion Include="xunit.v3" Version="4.0.0" />
-    <PackageVersion Include="Xunit.Combinatorial" Version="2.1.41" />
+    <PackageVersion Include="xunit.v3" Version="4.0.1" />
+    <PackageVersion Include="Xunit.Combinatorial" Version="2.1.43" />
     <PackageVersion Include="System.IO.Abstractions" Version="22.2.0" />
     <PackageVersion Include="System.CommandLine" Version="2.0.7" />
     <PackageVersion Include="Wcwidth" Version="4.0.1" />
@@ -37,7 +40,7 @@
     <PackageVersion Include="ColorHelper" Version="1.8.1" />
     <PackageVersion Include="TextMateSharp" Version="2.0.4" />
     <PackageVersion Include="TextMateSharp.Grammars" Version="2.0.4" />
-    <PackageVersion Include="Markdig" Version="1.3.2" />
+    <PackageVersion Include="Markdig" Version="1.4.0" />
     <PackageVersion Include="Serilog" Version="4.4.0" />
     <PackageVersion Include="Serilog.Extensions.Logging" Version="10.0.0" />
     <PackageVersion Include="Serilog.Sinks.Debug" Version="3.0.0" />
@@ -49,7 +52,7 @@
     <PackageVersion Include="ReactiveUI" Version="23.2.27" />
     <PackageVersion Include="ReactiveMarbles.ObservableEvents.SourceGenerator" Version="1.3.1" />
     <PackageVersion Include="ReactiveUI.SourceGenerators" Version="2.6.30" />
-    <PackageVersion Include="Moq" Version="4.20.72" />
+    <PackageVersion Include="Moq" Version="4.21.0" />
     <PackageVersion Include="ReportGenerator" Version="5.5.9" />
     <PackageVersion Include="coverlet.collector" Version="10.0.0" />
     <PackageVersion Include="GitVersion.MsBuild" Version="6.8.2" />

Terminal.Gui.Analyzers/Terminal.Gui.Analyzers.csproj

@@ -0,0 +1,24 @@
+<Project Sdk="Microsoft.NET.Sdk">
+
+    <PropertyGroup>
+        <!-- Roslyn Analyzers must target netstandard2.0 for MSBuild and Visual Studio compatibility -->
+        <TargetFramework>netstandard2.0</TargetFramework>
+        <LangVersion>Latest</LangVersion>
+        <Nullable>enable</Nullable>
+        <RootNamespace>Terminal.Gui.Analyzers</RootNamespace>
+        <EnforceExtendedAnalyzerRules>true</EnforceExtendedAnalyzerRules>
+        <IsRoslynComponent>true</IsRoslynComponent>
+        <NoWarn>$(NoWarn);RS2008;RS1032;RS1038</NoWarn>
+    </PropertyGroup>
+
+
+    <ItemGroup>
+        <PackageReference Include="Microsoft.CodeAnalysis.Analyzers">
+            <PrivateAssets>all</PrivateAssets>
+            <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+        </PackageReference>
+        <PackageReference Include="Microsoft.CodeAnalysis.CSharp" />
+        <PackageReference Include="Microsoft.CodeAnalysis.CSharp.Workspaces" />
+    </ItemGroup>
+
+</Project>

Terminal.Gui.Analyzers/V1ApiCodeFixProvider.cs

@@ -0,0 +1,108 @@
+using System.Collections.Immutable;
+using System.Composition;
+using System.Threading;
+using System.Threading.Tasks;
+using Microsoft.CodeAnalysis;
+using Microsoft.CodeAnalysis.CodeActions;
+using Microsoft.CodeAnalysis.CodeFixes;
+using Microsoft.CodeAnalysis.CSharp;
+using Microsoft.CodeAnalysis.CSharp.Syntax;
+
+namespace Terminal.Gui.Analyzers
+{
+    [ExportCodeFixProvider(LanguageNames.CSharp, Name = nameof(V1ApiCodeFixProvider)), Shared]
+    public class V1ApiCodeFixProvider : CodeFixProvider
+    {
+        public sealed override ImmutableArray<string> FixableDiagnosticIds => ImmutableArray.Create(new[] {
+            V1ApiDiagnosticAnalyzer.RuleClicked.Id,
+            V1ApiDiagnosticAnalyzer.RuleToplevel.Id,
+            V1ApiDiagnosticAnalyzer.RuleBounds.Id,
+            V1ApiDiagnosticAnalyzer.RuleTabView.Id,
+            V1ApiDiagnosticAnalyzer.RuleRadioGroup.Id,
+            V1ApiDiagnosticAnalyzer.RuleAcceptingIgnoresArgs.Id });
+
+        public sealed override FixAllProvider GetFixAllProvider() => WellKnownFixAllProviders.BatchFixer;
+
+        public sealed override async Task RegisterCodeFixesAsync(CodeFixContext context)
+        {
+            var root = await context.Document.GetSyntaxRootAsync(context.CancellationToken).ConfigureAwait(false);
+            if (root == null)
+            {
+                return;
+            }
+
+            foreach (var diagnostic in context.Diagnostics)
+            {
+                var diagnosticSpan = diagnostic.Location.SourceSpan;
+                var token = root.FindToken(diagnosticSpan.Start);
+
+                if (diagnostic.Id == V1ApiDiagnosticAnalyzer.RuleClicked.Id)
+                {
+                    context.RegisterCodeFix(
+                        CodeAction.Create(
+                            title: "Replace with 'Accepted'",
+                            createChangedDocument: c => ReplaceTokenAsync(context.Document, root, token, "Accepted", c),
+                            equivalenceKey: "UseAccepted"),
+                        diagnostic);
+                }
+                else if (diagnostic.Id == V1ApiDiagnosticAnalyzer.RuleBounds.Id)
+                {
+                    context.RegisterCodeFix(
+                        CodeAction.Create(
+                            title: "Replace with 'Viewport'",
+                            createChangedDocument: c => ReplaceTokenAsync(context.Document, root, token, "Viewport", c),
+                            equivalenceKey: "UseViewport"),
+                        diagnostic);
+                }
+                else if (diagnostic.Id == V1ApiDiagnosticAnalyzer.RuleToplevel.Id)
+                {
+                    context.RegisterCodeFix(
+                        CodeAction.Create(
+                            title: "Replace with 'Window'",
+                            createChangedDocument: c => ReplaceTokenAsync(context.Document, root, token, "Window", c),
+                            equivalenceKey: "UseWindow"),
+                        diagnostic);
+                }
+                else if (diagnostic.Id == V1ApiDiagnosticAnalyzer.RuleTabView.Id)
+                {
+                    context.RegisterCodeFix(
+                        CodeAction.Create(
+                            title: "Replace with 'Tabs'",
+                            createChangedDocument: c => ReplaceTokenAsync(context.Document, root, token, "Tabs", c),
+                            equivalenceKey: "UseTabs"),
+                        diagnostic);
+                }
+                else if (diagnostic.Id == V1ApiDiagnosticAnalyzer.RuleRadioGroup.Id)
+                {
+                    context.RegisterCodeFix(
+                        CodeAction.Create(
+                            title: "Replace with 'OptionSelector'",
+                            createChangedDocument: c => ReplaceTokenAsync(context.Document, root, token, "OptionSelector", c),
+                            equivalenceKey: "UseOptionSelector"),
+                        diagnostic);
+                }
+                else if (diagnostic.Id == V1ApiDiagnosticAnalyzer.RuleAcceptingIgnoresArgs.Id)
+                {
+                    var node = root.FindNode(diagnosticSpan);
+                    if (node is AssignmentExpressionSyntax assignment && assignment.Left is MemberAccessExpressionSyntax memberAccess)
+                    {
+                        var eventToken = memberAccess.Name.Identifier;
+                        context.RegisterCodeFix(
+                            CodeAction.Create(
+                                title: "Switch event to 'Accepted'",
+                                createChangedDocument: c => ReplaceTokenAsync(context.Document, root, eventToken, "Accepted", c),
+                                equivalenceKey: "SwitchToAccepted"),
+                            diagnostic);
+                    }
+                }
+            }
+        }
+
+        private static Task<Document> ReplaceTokenAsync(Document document, SyntaxNode root, SyntaxToken oldToken, string newName, CancellationToken cancellationToken)
+        {
+            var newToken = SyntaxFactory.Identifier(oldToken.LeadingTrivia, newName, oldToken.TrailingTrivia);
+            var newRoot = root.ReplaceToken(oldToken, newToken);
+            return Task.FromResult(document.WithSyntaxRoot(newRoot));
+        }
+    }
+}