Skip to content

Migrate JSON stack to System.Text.Json (drop Newtonsoft.Json) #3

Closed

Description

@tig

Tracks the "JSON stack" open item in PLAN.md §5.

Tasks

Legacy-cruft cleanup; pairs with the de-Microsoft rebrand.

Activity

  1. tig commented on Jun 23, 2026

    @tig
    MemberAuthor

    Done on develop in 2031bdf.

    The entire Newtonsoft footprint was a single [JsonIgnore] on DataTableColumn.Type (plus a // TODO: switch to System.Text.Json). System.Text.Json.Serialization exposes the same JsonIgnore attribute and ships in the net10 BCL, so:

    • using Newtonsoft.Json; → using System.Text.Json.Serialization;
    • Dropped the Newtonsoft.Json PackageReference (PSTui.Models) and PackageVersion (Directory.Packages.props) — no replacement package needed.

    grep confirms zero Newtonsoft references remain. The dead Serializers.cs that previously used TypeNameHandling.All was already removed in PowerShell#267. Closing once CI (#1) confirms the build.


    Generated by Claude Code

  2. tig commented on Jun 23, 2026

    @tig
    MemberAuthor

    ✅ Confirmed green. CI now runs on develop (build + xUnit) across windows/macos/ubuntu — 78/78 tests pass on .NET 10 with the System.Text.Json migration in place. grep shows zero Newtonsoft references remaining. Run: https://github.com/gui-cs/PSTui/actions/runs/28041156533

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions