You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Migrate JSON stack to System.Text.Json (drop Newtonsoft.Json) #3
The entire Newtonsoft footprint was a single [JsonIgnore] on DataTableColumn.Type (plus a // TODO: switch to System.Text.Json). System.Text.Json.Serialization exposes the same JsonIgnore attribute and ships in the net10 BCL, so:
using Newtonsoft.Json; → using System.Text.Json.Serialization;
Dropped the Newtonsoft.JsonPackageReference (PSTui.Models) and PackageVersion (Directory.Packages.props) — no replacement package needed.
grep confirms zero Newtonsoft references remain. The dead Serializers.cs that previously used TypeNameHandling.All was already removed in PowerShell#267. Closing once CI (#1) confirms the build.
✅ Confirmed green. CI now runs on develop (build + xUnit) across windows/macos/ubuntu — 78/78 tests pass on .NET 10 with the System.Text.Json migration in place. grep shows zero Newtonsoft references remaining. Run: https://github.com/gui-cs/PSTui/actions/runs/28041156533
Activity
Replace Newtonsoft.Json with System.Text.Json (#3)
tig commentedon Jun 23, 2026
Done on
developin 2031bdf.The entire Newtonsoft footprint was a single
[JsonIgnore]onDataTableColumn.Type(plus a// TODO: switch to System.Text.Json).System.Text.Json.Serializationexposes the sameJsonIgnoreattribute and ships in the net10 BCL, so:using Newtonsoft.Json;→using System.Text.Json.Serialization;Newtonsoft.JsonPackageReference(PSTui.Models) andPackageVersion(Directory.Packages.props) — no replacement package needed.grepconfirms zeroNewtonsoftreferences remain. The deadSerializers.csthat previously usedTypeNameHandling.Allwas already removed in PowerShell#267. Closing once CI (#1) confirms the build.Generated by Claude Code
tig commentedon Jun 23, 2026
✅ Confirmed green. CI now runs on
develop(build + xUnit) across windows/macos/ubuntu — 78/78 tests pass on .NET 10 with theSystem.Text.Jsonmigration in place.grepshows zeroNewtonsoftreferences remaining. Run: https://github.com/gui-cs/PSTui/actions/runs/28041156533