Skip to content

fix: skip recovery for already-connected same-net pairs - #1213

Open
GokulPandi-M wants to merge 3 commits into
tscircuit:mainfrom
GokulPandi-M:fix/redundant-near-parallel-same-net-routes
Open

GokulPandi-M wants to merge 3 commits into
tscircuit:mainfrom
GokulPandi-M:fix/redundant-near-parallel-same-net-routes

Conversation

@GokulPandi-M

@GokulPandi-M GokulPandi-M commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Reproduction

Reproduction: #1211. Until that PR merges, this branch carries the same captured solver input so the fix PR can show the corrected snapshot from the exact pipeline repro.

Summary

  • Skips unrouted-trace recovery when both endpoints are already joined through intersecting traces on the same net.
  • Prevents recovery from adding the redundant route that becomes a near-parallel VREF branch.
  • Adds a focused unit test and updates the exact acoustic-tuner pipeline assertion and SVG snapshot.

Implementation

Recovery builds the connected component containing the first endpoint from existing same-net traces. Traces join that component when they share a pin or intersect geometrically. If the second endpoint is already in that component, no additional route is generated.

The rule uses only net identity and trace geometry; it has no component names, circuit-specific coordinates, or spacing thresholds.

Validation

  • bun test — 407 passed, 4 skipped
  • bunx tsc --noEmit
  • bun run format:check
  • Exact pipeline repro assertion confirms the near-parallel VREF overlap is absent
  • Corrected full schematic SVG snapshot inspected locally

@vercel

vercel Bot commented Sep 16, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
schematic-trace-solver Ready Ready Preview Sep 16, 2026 6:49pm UTC

Request Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant