Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Automatic rail recovery can send AM3352 J_SD.4 down several units to reach J_I2C's V3V3 rail. Prefer a local label when an optional connection travels more than 1 schematic unit downward toward power, or 1 unit upward toward ground. Also cap total vertical travel at 4 units, even in the preferred direction; lateral travel does not consume this budget.
Measure the routed path from each candidate terminal to the shared label, stopping at that label. A large height difference between terminals is valid when both approach the label in the correct direction. For example, V_IN.2 and C1.2 in
bug-report-20260707T141421Zremain connected because their shared GND anchor lies below both pins; that snapshot is unchanged.availableNetLabelOrientations.On AM3352, J_SD receives its own upward V3V3 label. J_SPI and J_I2C use separate ground labels, while their power pins can share an upper V3V3 rail.
Review
Two recovery solvers use a shared policy and path-traversal helper. Regression tests cover the 1-unit boundary in both directions, endpoint reversal, correct-direction joins, aliases, explicit wiring, detours, junctions, the reported GND connection, C1’s excessive 7.42-unit drop in
bug-report-20260716T144856Z, and the AM3352 output. C1 now uses a local GND label. There are 19 reviewed snapshot changes relative to the merged reproduction baseline.This is a recovery preference based on the available label layout, not a global constraint on primary wiring or every subsequent layout operation.
Validation
bun test: 429 pass, 4 skip, 0 fail across 264 filesbunx tsc --noEmit: passesgit diff --check: pass