fix: treat isGround aliases as ground, not only the name GND - #1107
Open
Flame119052 wants to merge 1 commit into
Open
Flame119052 wants to merge 1 commit into
Flame119052 wants to merge 1 commit into
Conversation
Core already marks AGND, VSS, USB_GND, and similar nets isGround. Three solver paths still keyed off the literal net name "GND", so manually named ground nets skipped rail policy, recovery skip, and outer-column label placement. Fixes tscircuit#747
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ground rail policy, unrouted-trace recovery skip, and outer-column GND label placement all looked up the literal net name
"GND". Core already setsisGroundon aliases (AGND,VSS,USB_GND, …), so those nets were treated as ordinary signals.This collects every connectivity id that is either the canonical
GNDname (existing fixtures) or anisGroundnet connection, and uses that set in the three call sites.Fixes #747
Test plan
bun test(352 pass, 4 skip)tsc --noEmitisGroundapplies rail policy, skips recovery, and moves the shared rail label to the outer columnGNDwithoutisGroundstill worksRETURN/VDDare not treated as ground