Skip to content

docs: require Node 24 for the eve agent - #209

Open
nlee94 wants to merge 1 commit into
trycompai:mainfrom
nlee94:docs/node-24
Open

docs: require Node 24 for the eve agent#209
nlee94 wants to merge 1 commit into
trycompai:mainfrom
nlee94:docs/node-24

Conversation

@nlee94

@nlee94 nlee94 commented Sep 5, 2026

Copy link
Copy Markdown

What changed

  • package.json: engines.node goes from >=22 to >=24.
  • README.md: the quick start now lists Node.js 24 beside Bun and Docker, and says which runtime runs what.

Why

eve 0.29.4, which runs the agent, refuses to start below Node 24. Next.js also needs a real Node, because Turbopack's hashed external-module aliases do not resolve under Bun's runtime. A fresh clone on a machine with only Bun fails at bun run dev twice, and the docs never mention Node.

For the reviewer

Documentation only. Bun does not enforce engines, so the bump changes the number the next self-hoster reads, not the build.

🤖 Generated with Claude Code


Summary by cubic

Raises the documented Node requirement to 24 and bumps package.json engines to match, so the quick start reflects what the eve agent actually needs.

The eve agent (0.29.4) refuses to start below Node 24, and Next.js requires a real Node runtime because Turbopack's external-module aliases don't resolve under Bun. Previously the docs only mentioned Bun and Docker, so a fresh clone could fail at bun run dev with no hint. Since Bun does not enforce engines, this changes the documented requirement, not the build.

Written for commit a770ae7. Summary will update on new commits.

Review in cubic

The root package.json declared engines.node >=22, and the README listed
only Bun and Docker as prerequisites. eve 0.29.4, which runs the agent,
refuses to start on anything below Node 24, and Next.js needs a real Node
because Turbopack's external-module aliases do not resolve under Bun's
runtime. A clone on a machine without Node 24 fails at `bun run dev` with
no hint from the docs.

Bump the engines floor to 24 and say in the quick start which runtime
runs what.
@vercel

vercel Bot commented Sep 5, 2026

Copy link
Copy Markdown

@nlee94 is attempting to deploy a commit to the Comp AI - PoC Team on Vercel.

A member of the Team first needs to authorize it.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 2 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="package.json">

<violation number="1" location="package.json:35">
P3: The PR describes the engines bump as documentation-only because Bun does not enforce `engines`, but this repo is deployed on Vercel, and Vercel reads `engines.node` from the root package.json to select the Node.js build and serverless runtime version. So this change does alter the production Node runtime to 24, not just the number a self-hoster reads. That is likely intended (eve requires Node 24), but the stated rationale is inaccurate, so verify the Vercel build/runtime behaves as expected rather than assuming there is no build impact.</violation>
</file>

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread package.json
},
"engines": {
"node": ">=22"
"node": ">=24"

@cubic-dev-ai cubic-dev-ai Bot Sep 5, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3: The PR describes the engines bump as documentation-only because Bun does not enforce engines, but this repo is deployed on Vercel, and Vercel reads engines.node from the root package.json to select the Node.js build and serverless runtime version. So this change does alter the production Node runtime to 24, not just the number a self-hoster reads. That is likely intended (eve requires Node 24), but the stated rationale is inaccurate, so verify the Vercel build/runtime behaves as expected rather than assuming there is no build impact.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At package.json, line 35:

<comment>The PR describes the engines bump as documentation-only because Bun does not enforce `engines`, but this repo is deployed on Vercel, and Vercel reads `engines.node` from the root package.json to select the Node.js build and serverless runtime version. So this change does alter the production Node runtime to 24, not just the number a self-hoster reads. That is likely intended (eve requires Node 24), but the stated rationale is inaccurate, so verify the Vercel build/runtime behaves as expected rather than assuming there is no build impact.</comment>

<file context>
@@ -32,7 +32,7 @@
 	},
 	"engines": {
-		"node": ">=22"
+		"node": ">=24"
 	},
 	"packageManager": "bun@1.3.12",
</file context>
Fix with cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant