Repository navigation
Conversation
… layout (#317) * fix(release): compare the production private runtime with its channel identity normalised The production pair check compared the sha256 of the whole track-b-runtime manifest, which embeds runtimeChannelContext built from ROLE_MODEL_BUILD_CHANNEL. A production package therefore never equalled the stage candidate (measured on v0.0.16: 5ffdc9a4 vs a538e566, differing in that field alone) and no stable release could be built. The pair is now compared with that one field removed, while each side must still identify as its own channel. * test(release): exercise the production pair check across channel identities The previous fixture handed both sides the same manifest digest, which is exactly the assumption that made the impossible comparison look correct. The pair now differs by its channel identity (as real packages do), and the negative cases cover a genuine content difference, a stage runtime that does not identify as stage, and a missing runtime manifest. * fix(release): assemble production Track B from the accepted candidate layout Measured from the failed v0.0.16 production package: assembling Track B from .cache/paired-public made the private bundle embed "../paired-public/packages/..." where the tested candidate embedded "../../packages/...". That label alone changed publicRuntimeAdapter.artifactSha256 and registryBindings.contractRegistry.adapterSha256, so the production pair check rejected a package that was otherwise identical. Production now checks out the accepted candidate revision in the workspace (the stable gate already proves the tagged tree is that tree) and builds the private distribution against it, exactly as the stage job does.
fix(release): assemble production Track B from the accepted candidate layout
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes the accepted candidate stage-rc-8d421f83c8a0 to main. Production now assembles Track B from the accepted candidate checkout, so the private bundle matches the tested candidate byte for byte apart from the runtime channel identity - the condition the stable gate requires.