add PUT/POST/DELETE for monitoring-sets - #257
Merged
Merged
Conversation
Contributor
Author
|
Feedback from call:
|
This means adding a new media type for the monitoring set representation, since requiring name in the current v1 media type would be a breaking change. Per the [Media Type Versioning ADR](https://trolie.energy/decision-log/media-type-versioning.html), this requires updating the minor version of the TROLIE spec itself.
Contributor
Author
|
@getorymckeag @aidan-short-gevernova bump, can I get a review please? |
getorymckeag
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #254
@getorymckeag please review this at your convenience. In particular, I would call your attention to the rationale for the minor version change. Requiring
namefor a monitoring set media type would have been a breaking change, so we now have a v2 monitoring set media type. The commit history says it all.https://trolie.energy/decision-log/media-type-versioning.html#media-type-versions