Skip to content

Commit 32e9950

Browse files
committed
Set the defaultValue so there are some fields
1 parent 74d9923 commit 32e9950

1 file changed

Lines changed: 39 additions & 36 deletions

File tree

  • apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.environment-variables.new

apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.environment-variables.new/route.tsx

Lines changed: 39 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -207,6 +207,9 @@ export default function Page() {
207207
return parse(formData, { schema });
208208
},
209209
shouldRevalidate: "onSubmit",
210+
defaultValue: {
211+
variables: [{ key: "", value: "" }],
212+
},
210213
});
211214

212215
const handleEnvironmentChange = (
@@ -245,7 +248,7 @@ export default function Page() {
245248
setSelectedBranchId(undefined);
246249
} else {
247250
setSelectedBranchId(branchId);
248-
}
251+
}
249252
};
250253

251254
const [revealAll, setRevealAll] = useState(true);
@@ -273,8 +276,8 @@ export default function Page() {
273276
<input type="hidden" name="environmentIds" value={selectedBranchId} />
274277
) : (
275278
Array.from(selectedEnvironmentIds).map((id) => (
276-
<input key={id} type="hidden" name="environmentIds" value={id} />
277-
))
279+
<input key={id} type="hidden" name="environmentIds" value={id} />
280+
))
278281
)}
279282
<div className="flex items-center gap-2">
280283
{nonBranchEnvironments.map((environment) => (
@@ -346,31 +349,31 @@ export default function Page() {
346349
<InputGroup fullWidth>
347350
<Label>Select branch</Label>
348351
<div className="flex items-center gap-1">
349-
<Select
350-
variant="tertiary/medium"
352+
<Select
353+
variant="tertiary/medium"
351354
value={selectedBranchId ?? "all"}
352-
setValue={handleBranchChange}
355+
setValue={handleBranchChange}
353356
placeholder="All branches"
354357
items={[{ id: "all", branchName: "All branches" }, ...branchEnvironments]}
355358
className="w-fit min-w-52"
356-
filter={{
359+
filter={{
357360
keys: [
358361
(item) => item.branchName?.replace(/\//g, " ").replace(/_/g, " ") ?? "",
359362
],
360-
}}
363+
}}
361364
text={(val) =>
362365
val ? branchEnvironments.find((b) => b.id === val)?.branchName : null
363-
}
364-
dropdownIcon
365-
>
366-
{(matches) =>
367-
matches?.map((env) => (
368-
<SelectItem key={env.id} value={env.id}>
369-
{env.branchName}
370-
</SelectItem>
371-
))
372-
}
373-
</Select>
366+
}
367+
dropdownIcon
368+
>
369+
{(matches) =>
370+
matches?.map((env) => (
371+
<SelectItem key={env.id} value={env.id}>
372+
{env.branchName}
373+
</SelectItem>
374+
))
375+
}
376+
</Select>
374377
{selectedBranchId !== "all" && selectedBranchId !== undefined && (
375378
<Button
376379
variant="minimal/medium"
@@ -585,27 +588,27 @@ function VariableField({
585588
<fieldset ref={ref}>
586589
<FieldLayout>
587590
<div className="space-y-2">
588-
<Input
589-
id={`${formId}-${baseFieldName}.key`}
590-
name={`${baseFieldName}.key`}
591-
placeholder="e.g. CLIENT_KEY"
592-
value={value.key}
593-
onChange={(e) => onChange({ ...value, key: e.currentTarget.value })}
594-
autoFocus={index === 0}
595-
onPaste={onPaste}
596-
/>
591+
<Input
592+
id={`${formId}-${baseFieldName}.key`}
593+
name={`${baseFieldName}.key`}
594+
placeholder="e.g. CLIENT_KEY"
595+
value={value.key}
596+
onChange={(e) => onChange({ ...value, key: e.currentTarget.value })}
597+
autoFocus={index === 0}
598+
onPaste={onPaste}
599+
/>
597600
<FormError id={fields.key.errorId}>{fields.key.error}</FormError>
598601
</div>
599602
<div className={cn("flex items-start gap-1")}>
600603
<div className="grow space-y-2">
601-
<Input
602-
id={`${formId}-${baseFieldName}.value`}
603-
name={`${baseFieldName}.value`}
604-
type={showValue ? "text" : "password"}
605-
placeholder="Not set"
606-
value={value.value}
607-
onChange={(e) => onChange({ ...value, value: e.currentTarget.value })}
608-
/>
604+
<Input
605+
id={`${formId}-${baseFieldName}.value`}
606+
name={`${baseFieldName}.value`}
607+
type={showValue ? "text" : "password"}
608+
placeholder="Not set"
609+
value={value.value}
610+
onChange={(e) => onChange({ ...value, value: e.currentTarget.value })}
611+
/>
609612
<FormError id={fields.value.errorId}>{fields.value.error}</FormError>
610613
</div>
611614
{showDeleteButton && (

0 commit comments

Comments
 (0)