Skip to content

Commit 74d9923

Browse files
committed
Layout fix when there are errors
1 parent 25372d6 commit 74d9923

1 file changed

Lines changed: 7 additions & 5 deletions

File tree

  • apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.environment-variables.new

apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.environment-variables.new/route.tsx

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -584,6 +584,7 @@ function VariableField({
584584
return (
585585
<fieldset ref={ref}>
586586
<FieldLayout>
587+
<div className="space-y-2">
587588
<Input
588589
id={`${formId}-${baseFieldName}.key`}
589590
name={`${baseFieldName}.key`}
@@ -593,7 +594,10 @@ function VariableField({
593594
autoFocus={index === 0}
594595
onPaste={onPaste}
595596
/>
596-
<div className={cn("flex items-center justify-between gap-1")}>
597+
<FormError id={fields.key.errorId}>{fields.key.error}</FormError>
598+
</div>
599+
<div className={cn("flex items-start gap-1")}>
600+
<div className="grow space-y-2">
597601
<Input
598602
id={`${formId}-${baseFieldName}.value`}
599603
name={`${baseFieldName}.value`}
@@ -602,6 +606,8 @@ function VariableField({
602606
value={value.value}
603607
onChange={(e) => onChange({ ...value, value: e.currentTarget.value })}
604608
/>
609+
<FormError id={fields.value.errorId}>{fields.value.error}</FormError>
610+
</div>
605611
{showDeleteButton && (
606612
<Button
607613
variant="minimal/medium"
@@ -612,10 +618,6 @@ function VariableField({
612618
)}
613619
</div>
614620
</FieldLayout>
615-
<div className="space-y-2">
616-
<FormError id={fields.key.errorId}>{fields.key.error}</FormError>
617-
<FormError id={fields.value.errorId}>{fields.value.error}</FormError>
618-
</div>
619621
</fieldset>
620622
);
621623
}

0 commit comments

Comments
 (0)