Repository navigation
Chore/wallet import updates - #22
Merged
Merged
Conversation
- Updated the import treasury API to require the importing admin to be a base signer of the treasury script, enhancing security against unauthorized imports. - Modified related test cases to reflect the new signer validation logic and ensure accurate error handling. - Improved documentation to clarify the requirements for importing treasuries, emphasizing the need for wallet address matching with script keys.
- Added functionality to prompt users with a confirmation dialog when attempting to close the TaskModal with unsaved changes. - Updated the TaskModal component to track changes and determine if the user should be warned before closing. - Enhanced unit tests to cover scenarios for confirming or discarding unsaved changes when canceling edits. - Improved documentation to reflect the new behavior of the TaskModal regarding unsaved changes.
- Modified the BudgetsView component to clarify the description of budget functionalities. - Refactored BudgetProjectCard to utilize community-wide tokens for workgroups and improved treasury token handling. - Enhanced BudgetWorksheet to categorize budget cards under distinct sections for Workgroups and Treasuries, improving UI clarity. - Updated documentation to reflect changes in budget card organization and token availability. - Expanded tests to validate the new token handling logic and UI structure.
- Updated the BudgetsView component to include a slug prop for improved routing. - Enhanced BudgetProjectCard to display payment wallet information and links for editing details. - Refactored BudgetWorksheet to utilize workgroup treasury assignments for displaying routing notes. - Added new interfaces for workgroup and treasury routing notes to improve type safety. - Expanded tests to validate the display of routing notes and their integration with the budget worksheet. - Updated documentation to reflect changes in budget routing and wallet management.
- Changed references from "workgroups" to "workgroups & projects" in various components and documentation for consistency. - Updated UI elements, including titles and labels, to reflect the new terminology. - Enhanced descriptions and hints to clarify the functionality of workgroups and projects. - Adjusted tests to validate the updated terminology in the application. - Revised documentation to align with the new naming conventions and improve clarity on workgroup and project functionalities.
✅ Deploy Preview for treasuryguild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
…up properties in tests - Changed the type of heldTokensError in BudgetProjectCard from unknown to string | null for better type safety. - Updated workgroup properties in BudgetWorksheet tests to ensure consistent typing for treasury_id and archived_at fields.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.