docs(environment-setup): accuracy + copy/structure (no #192 dependency)#48
Merged
Conversation
Independent of the installer namespace change (client#192) -- safe to ship now. Accuracy: - Firewall domains: drop the misleading `github.com`; add ghcr.io (ingestor), raw.githubusercontent.com (scripts), *.github.io (chart repo). - Drop the phantom HTTP_PORT/HTTPS_PORT knobs (installer disables ingress). - Troubleshooting: document the `--diagnose` support bundle. Copy + structure: - EKS: "when to use EKS vs local" callout + back-link to setup-guide; Quick-vs-Detailed signpost; dropped softeners/verbosity. - Configuration: installer-vs-Helm audience signpost; tightened verbose lines. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
Author
|
👋 Heads-up — Code review queue is at 14 / 8 Above the WIP limit. The team convention is to review existing PRs before opening new work. Open PRs currently in Code review (oldest first):
Pull from review before opening new work. (This is a nudge from the kanban WIP check, not a block.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The #192-independent half of the Environment Setup audit, split out of #47 — correct against the current installer, safe to merge and promote now.
Accuracy
setup-guide): replaced the misleadinggithub.comwith what the installer actually hits —ghcr.io(ingestor image),raw.githubusercontent.com(install scripts),*.github.io(Helm chart repo). The old list breaks installs behind a strict firewall.configuration): removedHTTP_PORT/HTTPS_PORT— the installer disables ingress (traefik/servicelb) and binds only the API port.--diagnose(troubleshooting): documented the redacted support bundle (was missing).Copy + structure
The namespace/workspace edits (which describe client#192) stay in #47, held to merge with #192.
Validated: MDX components balanced,
docs.jsonvalid. Targetsdevelop.